public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jack Bonatakis <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: [email protected]
Subject: Re: Unable to log out of postgresql.org
Date: Fri, 20 Mar 2026 21:51:32 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABUevEzeBgmCaAnEy6jKh7viS5Ptuzi5i-sse01G8xE4XLtZfA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CABUevEzeBgmCaAnEy6jKh7viS5Ptuzi5i-sse01G8xE4XLtZfA@mail.gmail.com>

On Fri, Mar 20, 2026, at 2:26 PM, Magnus Hagander wrote:
> Nice spot.
> 
> However, this fix won't work. Putting a csrf token on every page is incompatible with the caching system we have in place.
> 
> One way to fix it would be to just allow logout GET again (I think this got broken on a django upgrade where it wasn't tested). But maybe the better way to fix it would be to have the logout link go to a page with a POST form on it, and have that form do what the GET link does now. I assume the GET is blocked because otherwise someone could trick a user, or redirect them, to the logout URL and they get logged out. I'm not sure how realistic or how big of a problem that is, but getting rid of it would not hurt...
> 
> Would you be interested in working on a patch for that as well?
> 
> //Magnus

Ah interesting. Yeah, it looks to be a change new with Django 5. I'll have to take a closer look at the existing caching system, but yes I'd be happy to work on an alternative to my patch above. Your proposal seems reasonable and might be the way to go.

Jack 

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Unable to log out of postgresql.org
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox