Message-ID: <880875d1-9e07-3776-3981-bbb96520302b@cmatte.me>
Date: Thu, 4 Nov 2021 16:46:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH] pgarchives: parser: handle messages in which Message-ID
 is missing
Content-Language: en-US
To: pgsql-www@lists.postgresql.org
References: <c12954dd-c19c-f809-f92c-116469c9543f@cmatte.me>
 <cd426669-d5fb-fe3e-b0c1-28c10866ff28@cmatte.me>
 <CABUevEw+NK=Rj2nc3_r7qqpshqoBheFMQv-J3Acid_S063PGOg@mail.gmail.com>
From: =?UTF-8?Q?C=c3=a9lestin_Matte?= <celestin.matte@cmatte.me>
In-Reply-To: 
 <CABUevEw+NK=Rj2nc3_r7qqpshqoBheFMQv-J3Acid_S063PGOg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/880875d1-9e07-3776-3981-bbb96520302b%40cmatte.me>
Precedence: bulk

> It's supposed to remove non-ascii characters.
> 
> I think this is a leftover from the py2->py3 conversion. It looks like an overenthusiastic regexp replacement in the 2to3 tool. See bb5775ef where it came from. I'll go change it to jut str(err).

Right. Beware that there are other similar failing conversions in the same commit on lines in loader/lib/parser.py that should be addressed as well

-- 
Célestin Matte