MIME-Version: 1.0
References: <ake43CicUsJNosbi@alvherre.pgsql>
In-Reply-To: <ake43CicUsJNosbi@alvherre.pgsql>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 3 Jul 2026 14:43:08 +0100
Message-ID: 
 <CA+OCxowRWHGLQxT7i27PnzsEroFOkkXBSBMEBCnVDU2w1sSD=w@mail.gmail.com>
Subject: Re: pglister: don't say "subject is empty" for non-empty subjects
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: "w^3" <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000096017b0655b51b42"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxowRWHGLQxT7i27PnzsEroFOkkXBSBMEBCnVDU2w1sSD%3Dw%40mail.gmail.com>
Precedence: bulk

--00000000000096017b0655b51b42
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 3 Jul 2026 at 14:30, =C3=81lvaro Herrera <alvherre@kurilemu.de> wro=
te:

> Hi
>
> We just got a complaint about a moderation message being unclear -- the
> moderation interface says that the subject is empty when it isn't.  I
> propose to reword the message.  Also, the constant name was already
> wrong, but now it is even more obvious how wrong it is, so update it.
>
> Proposed patch attached.
>

Looks good to me - thanks!

--=20
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com

--00000000000096017b0655b51b42
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, 3 Jul 2=
026 at 14:30, =C3=81lvaro Herrera &lt;<a href=3D"mailto:alvherre@kurilemu.d=
e">alvherre@kurilemu.de</a>&gt; wrote:<br></div><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex">Hi<br>
<br>
We just got a complaint about a moderation message being unclear -- the<br>
moderation interface says that the subject is empty when it isn&#39;t.=C2=
=A0 I<br>
propose to reword the message.=C2=A0 Also, the constant name was already<br=
>
wrong, but now it is even more obvious how wrong it is, so update it.<br>
<br>
Proposed patch attached.<br></blockquote><div><br></div><div>Looks good to =
me - thanks!</div><div>=C2=A0</div></div><span class=3D"gmail_signature_pre=
fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l=
tr">Dave Page<div>pgAdmin: <a href=3D"https://www.pgadmin.org" target=3D"_b=
lank">https://www.pgadmin.org</a></div><div>PostgreSQL: <a href=3D"https://=
www.postgresql.org" target=3D"_blank">https://www.postgresql.org</a></div><=
div>pgEdge: <a href=3D"https://www.pgedge.com" target=3D"_blank">https://ww=
w.pgedge.com</a><br><div></div><div><br></div></div></div></div></div>

--00000000000096017b0655b51b42--