Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vR5oN-006KFf-2w for pgsql-www@arkaria.postgresql.org; Thu, 04 Dec 2025 09:39:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vR5oM-00209N-39 for pgsql-www@arkaria.postgresql.org; Thu, 04 Dec 2025 09:39:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vR5oM-00209B-1y for pgsql-www@lists.postgresql.org; Thu, 04 Dec 2025 09:39:43 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vR5oK-00354L-0A for pgsql-www@lists.postgresql.org; Thu, 04 Dec 2025 09:39:42 +0000 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5959b2f3fc9so687340e87.2 for ; Thu, 04 Dec 2025 01:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1764841179; x=1765445979; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nhSWjnEldb5lCW+Hz+mL1Qftm2Q8z/Wyk5RdCw0wubM=; b=lNr22DyhEWSufLjvW5KAspbSUlTIodL0pYEciPTay6epLAbKMDA0huoD13H9K0nV+0 Y1ulf4o2MSAb/86wmvfUQSpgoMlBmuFXFoa8DQ2fnYvxDwbutAjj6gNaR5qQU6VMMCkX SlMOgG4M0mTJ8urlIbJNtv01WGbPZ/7vgcBga9E/5kIJSDlOikDALQd/BXh4ej8Ju0Yt Y5PwHBj6PvLHVn3eIkvtLnmlXrWNEL5+JXbcnTehC6FH02Jx92UR2cUkrlH91qhwfedS wnNGtivWYRgwpqSk9nVkJAfIMuoWoRlPyx3Kw31SZ5bfDfyhXhiOSOz9kX+RWzc5nN5g ddcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764841179; x=1765445979; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nhSWjnEldb5lCW+Hz+mL1Qftm2Q8z/Wyk5RdCw0wubM=; b=eiNMDkfs68JPzOcyUKcqLn+LPT8brrsYFMbRhUDDXWaL5qbiJXUxsmJPMvZYau7lGp zKVQC9MYjyagwHLNcdnEN15S8B5WU5qiF4k6fzBKbcYcdjGtbHXSPIEISynRplkmP77p hp4KZWMaX9/A7ERAsCJO5xyl0FYRxuT7lio7h2Xs7O17505NrNchNsWS4inTsSUygd7q VqYp9UnN977GGFZ4aG52pybR23Ia9CuHACsnOGhTbjFkyqGLaVB3N/SqzNLPUYnqUa1h YqbZZWmLzha/z8cLNYOzrLPk52PXmT3D6Fbxo9IiWMtZT5w20M+DbFq32osnfujUcE9C iTwQ== X-Gm-Message-State: AOJu0Yz+UJNfVNmb8mMsRlvQRPS6aHG5nFX9Y1dYwF0cI1tFxXDWEDG0 mk66hkStagZdBiR+VAQ1A/F7fWrZJuXf3lsTP8g7X0ee/ZY3rFTVdJD91SV/3fZ8/2lVwys6YDg IN6DP9MvnZz4pUgYlHNFVkenHD4uAMF1bdsrhsnkS X-Gm-Gg: ASbGnctOqc6FKOd6qnCvce+nsGlQ2maGu1wu+dWnQdx0ZSrWf64JEVotlJKiKtrEMqx nHCYkyaHBrQaQZ6NJCacfIFE+WZ4gxxHwXWgSJX+8KONldFJyRhjupMPFaCp8KWY3l4a1/vlSUV 8YHoZrHAzmRrVfm9ekCtYiez3QyXFhXvyqaNCzZj0bqMPvJ+gTGBiUYstMX8kkrd17Xiv0bvIxj uQWPxxja0zgz24dX/qA43LRw7ERH6dYheOoiRuviN/HXQbjo1BQyEYUN23DMxKNyoiPYQYoOg== X-Google-Smtp-Source: AGHT+IEfPwqovQfnnfBt9HY/1us2UhP+eirGQKzlerbpTPdVDMMuYeYo4wC6FLxzPewFc3Mn2/4Oswgg6icluJHvL8U= X-Received: by 2002:ac2:4c4b:0:b0:594:2d39:106c with SMTP id 2adb3069b0e04-597d3fe37f1mr2208803e87.42.1764841178978; Thu, 04 Dec 2025 01:39:38 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 4 Dec 2025 09:39:27 +0000 X-Gm-Features: AWmQ_bmSHmDJrcjKskqV7xIhgDXFUsPaP0P9eqj-p4FuCnbkZ3n2qmh0DwDcDaw Message-ID: Subject: Re: Copy script button cleanup To: Magnus Hagander Cc: PostgreSQL WWW Content-Type: multipart/alternative; boundary="0000000000008eeb0f06451d1bc9" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000008eeb0f06451d1bc9 Content-Type: text/plain; charset="UTF-8" On Wed, 3 Dec 2025 at 22:29, Magnus Hagander wrote: > On Wed, 3 Dec 2025 at 11:38, Dave Page wrote: > >> >> >> On Tue, 2 Dec 2025 at 14:41, Magnus Hagander wrote: >> >>> >>> >>> On Tue, 2 Dec 2025 at 12:30, Dave Page wrote: >>> >>>> The Copy Script buttons on the Linux package installation pages look >>>> horrific. See before.png. >>>> >>>> The attached patch makes them look much nicer, with proper sizing and >>>> an icon based button. On click, it briefly changes to a green checkmark to >>>> show confirmation. See the after screenshots. >>>> >>>> I'll apply this in a couple of days if there are no objections. >>>> >>>> >>> LGTM in general and certainly is a lot prettier. >>> >>> Can you explain what that "fallback for text based buttons" is? Aren't >>> they all replaced with icons? >>> >> >> Oh, yeah. That's no longer needed now the patch is complete. I'll remove >> it. >> >> >>> >>> Oh, and I'm told you're not supposed to use "var" for variables in js >>> due to the broken scoping :) >>> >> >> Old habits die hard :-( >> >> >>> >>> And while you're poking at it, one thing I've really wanted is a "copy >>> without the sudo parts". But I'm guessing that would be a lot more >>> complicated than what you're fixing here... >>> >> >> Ask and thou shalt receive. >> > > Sweet! :) > > > 2 patches attached. Both fix the original issue. One also adds the no sudo >> button. >> >> > Looks good in a (fairly brief) check. Thanks! > Thanks - I fixed one more minor styling issue (minimum height of the code boxes), and applied the no-sudo version. -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org pgEdge: https://www.pgedge.com --0000000000008eeb0f06451d1bc9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, 3 Dec 2= 025 at 22:29, Magnus Hagander <ma= gnus@hagander.net> wrote:
On Wed, 3 Dec 2025 at 11:38, Dave Page <dpage@pgadmin.org> wrote:


On Tue, 2 Dec 2025 at 14:41, Magnus Hagander <magnus@hagander.net> wro= te:

<= br>
On Tue,= 2 Dec 2025 at 12:30, Dave Page <dpage@pgadmin.org> wrote:
=
The Copy Script buttons on the Linux package installa= tion pages look horrific. See before.png.

The atta= ched patch makes them look much nicer, with proper sizing and an icon based= button. On click, it briefly changes to a green checkmark to show confirma= tion. See the after screenshots.

I'll apply th= is in a couple of days if there are no objections.


LGTM in general and certainly is a lot p= rettier.

Can you explain what that "fallback = for text based buttons" is?=C2=A0 Aren't they all replaced with ic= ons?

Oh, yeah. That's= no longer needed now the patch is complete. I'll remove it.
= =C2=A0

Oh, and I'm told you're not supposed to use "= ;var" for variables in js due to the broken scoping :)

Old habits die hard :-(
=C2=A0=

And while you&#= 39;re poking at it, one thing I've really wanted is a "copy withou= t the sudo parts". But I'm guessing that would be a lot more compl= icated than what you're fixing here...
Ask and thou shalt receive.
=
Sweet! :)


2 patches attached. Both= fix the original issue. One also adds the no sudo button.


Looks good in a (fairly br= ief) check. Thanks!

Thank= s - I fixed one more minor styling issue (minimum height of the code boxes)= , and applied the no-sudo version.
=C2=A0
--
--0000000000008eeb0f06451d1bc9--