public inbox for [email protected]  
help / color / mirror / Atom feed
From: Melanie Plageman <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Bossart, Nathan <[email protected]>
Subject: Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section
Date: Fri, 10 Jan 2025 18:31:04 -0500
Message-ID: <CAAKRu_ZochwEBbY7_1n8z_-c5Zvh1EggBkEhYn2i9X4A5LD4ww@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAAKRu_aQUOaMYrcjNuXeSkJtaX9oRUzKP57bsYbC0gVVWS+cbA@mail.gmail.com>
	<[email protected]>
	<CAAKRu_bz3BD4w0jmjfQkckAQE5eb-Ge2a=9Q-HG_rWSTeG_PzA@mail.gmail.com>
	<CAAKRu_Ymux_RBzp5faSR5-qx1JdM6qS3POVjcWyHbnQjzgmo8g@mail.gmail.com>
	<[email protected]>
	<CAAKRu_ZR8aqiZ0SHK8Rqd7QVAmr6XX9Xpkie9vmZAkyb69YOiQ@mail.gmail.com>
	<[email protected]>
	<CAAKRu_a52vCax5+AN7MstfMckuR1qxyfTmssyPhqZv+9mNiMGQ@mail.gmail.com>
	<[email protected]>

On Fri, Jan 10, 2025 at 6:00 PM Daniel Gustafsson <[email protected]> wrote:
>
> > On 10 Jan 2025, at 23:09, Melanie Plageman <[email protected]> wrote:
> >
> > On Thu, Jan 9, 2025 at 5:05 PM Daniel Gustafsson <[email protected]> wrote:
> >>
> >> I think this is a really good restructuring which will make life easier for our
> >> users.  Some of the comments below are on wording which wasn't introduced in
> >> this patch, but which I hadn't thought about before, so feel free to ignore
> >> those comments.
> >>
> >> +    <sect2 id="runtime-config-vacuum-freezing">
> >> +     <title>Freezing</title>
> >> +
> >> +     <para>
> >> Trying to read this as a new user, I think it would be good to start this
> >> subsection with a sentence describing what freezing actually is.  Vacuum is
> >> hard enough for users as it is =)
> >
> > I've taken a stab at improving this. Let me know if you think it works.
>
> I like what you added, it's IMO the right level of detail here.

Cool, thanks! I pushed.

> +         Specifies the cutoff age (in multixacts) that <command>VACUUM</command>
> I wish we had a glossary entry for multixact we could link to here.  But,
> that's not really the responsibility of this patch to fix, just something that
> came to mind when reading the resulting page.

Personally, I really wish we had a docs page explaining more about
what mutlixacts are and maybe even a bit about the architecture. FWIW,
the index [1] has an entry for MultiXacts but it goes straight to
MultiXacts and Wraparound [2].

- Melanie

[1] https://www.postgresql.org/docs/devel/bookindex.html
[2] https://www.postgresql.org/docs/devel/routine-vacuuming.html#VACUUM-FOR-MULTIXACT-WRAPAROUND





view thread (21+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section
  In-Reply-To: <CAAKRu_ZochwEBbY7_1n8z_-c5Zvh1EggBkEhYn2i9X4A5LD4ww@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox