MIME-Version: 1.0
References: <c12954dd-c19c-f809-f92c-116469c9543f@cmatte.me>
 <cd426669-d5fb-fe3e-b0c1-28c10866ff28@cmatte.me>
In-Reply-To: <cd426669-d5fb-fe3e-b0c1-28c10866ff28@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Thu, 4 Nov 2021 11:35:41 +0100
Message-ID: 
 <CABUevEw+NK=Rj2nc3_r7qqpshqoBheFMQv-J3Acid_S063PGOg@mail.gmail.com>
Subject: Re: [PATCH] pgarchives: parser: handle messages in which Message-ID
 is missing
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: pgsql-www@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000044383505cff41725"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEw%2BNK%3DRj2nc3_r7qqpshqoBheFMQv-J3Acid_S063PGOg%40mail.gmail.com>
Precedence: bulk

--00000000000044383505cff41725
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 3, 2021 at 6:05 PM C=C3=A9lestin Matte <celestin.matte@cmatte.m=
e>
wrote:

> By the way, loader/load_message.py has a double crash issue, when
> importing a message raising an IgnorableException:
>
> [...]
> During handling of the above exception, another exception occurred:
>
> Traceback (most recent call last):
>   File "/srv/pgarchives/local//loader/load_message.py", line 155, in
> <module>
>     log_failed_message(listid, "mbox", opt.mbox, ap, e)
>   File "/srv/pgarchives/local//loader/load_message.py", line 36, in
> log_failed_message
>     'err': str(str(err), 'us-ascii', 'replace'),
> TypeError: decoding str is not supported
>
> I don't understand what this line is supposed to do (removing non-ascii
> characters?), but a simple str(err) fixes the issue.
>

It's supposed to remove non-ascii characters.

I think this is a leftover from the py2->py3 conversion. It looks like an
overenthusiastic regexp replacement in the 2to3 tool. See bb5775ef where it
came from. I'll go change it to jut str(err).

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--00000000000044383505cff41725
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Nov 3, 2021 at 6:05 PM C=C3=
=A9lestin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.ma=
tte@cmatte.me</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">By the way, loader/load_message.py has a double crash issue, w=
hen importing a message raising an IgnorableException:<br>
<br>
[...]<br>
During handling of the above exception, another exception occurred:<br>
<br>
Traceback (most recent call last):<br>
=C2=A0 File &quot;/srv/pgarchives/local//loader/load_message.py&quot;, line=
 155, in &lt;module&gt;<br>
=C2=A0 =C2=A0 log_failed_message(listid, &quot;mbox&quot;, opt.mbox, ap, e)=
<br>
=C2=A0 File &quot;/srv/pgarchives/local//loader/load_message.py&quot;, line=
 36, in log_failed_message<br>
=C2=A0 =C2=A0 &#39;err&#39;: str(str(err), &#39;us-ascii&#39;, &#39;replace=
&#39;),<br>
TypeError: decoding str is not supported<br>
<br>
I don&#39;t understand what this line is supposed to do (removing non-ascii=
 characters?), but a simple str(err) fixes the issue.<br></blockquote><div>=
<br></div><div>It&#39;s supposed to remove non-ascii characters.</div><div>=
<br></div><div>I think this is a leftover from the py2-&gt;py3 conversion. =
It looks like an overenthusiastic regexp=C2=A0replacement in the 2to3 tool.=
 See=C2=A0bb5775ef where it came from. I&#39;ll go change it to jut str(err=
).</div></div><div><br></div>-- <br><div dir=3D"ltr" class=3D"gmail_signatu=
re"><div dir=3D"ltr"><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a href=3D"htt=
p://www.hagander.net/" target=3D"_blank">https://www.hagander.net/</a><br>=
=C2=A0Work: <a href=3D"http://www.redpill-linpro.com/" target=3D"_blank">ht=
tps://www.redpill-linpro.com/</a></div></div></div></div>

--00000000000044383505cff41725--