Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vQvLV-0029oI-2g for pgsql-www@arkaria.postgresql.org; Wed, 03 Dec 2025 22:29:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vQvLU-00GmuX-0I for pgsql-www@arkaria.postgresql.org; Wed, 03 Dec 2025 22:29:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vQvLT-00GmuP-2M for pgsql-www@lists.postgresql.org; Wed, 03 Dec 2025 22:29:12 +0000 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vQvLQ-0030Av-3D for pgsql-www@lists.postgresql.org; Wed, 03 Dec 2025 22:29:10 +0000 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-789314f0920so2530727b3.1 for ; Wed, 03 Dec 2025 14:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander.net; s=mail; t=1764800949; x=1765405749; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hm1Uz0NvfS+8U0B8a12dbk/HLMM/ox7GUY+RTz3nOwo=; b=W/JCEfZ/w8F2angTt77yv9b1u+Dir3sSrCOdSc6boCQC0x/k8QI272jIBudl4Q1Vhj YUS9WkraCA0ROChIIBwMglPZ6KGxlUmsugeBKmE7U1kIfCFDVGZml+og/nIsRCuo3Eer R1tUO8qRjHaFTe2PzmF+4O84EFQb/Vq3y5X0Ms8TwajksrNf7m8qfhUA1WZ2PUCa2gir m4B/zMPoPr1K28CdisWHfy1xEk/7zfLSzAkcBNoK0yb0HlaMmBy3X5FoK2WXZ0rel6GB nGd8lz9HJKwlP7AoEao2Wxb709vu8MKyU1lJtG/qxTeGkaCJ5BEMcXDe7cEx8BiIi9y2 uFFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764800949; x=1765405749; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hm1Uz0NvfS+8U0B8a12dbk/HLMM/ox7GUY+RTz3nOwo=; b=GR5tbqhVusMdl9VG/G6ub877/kIvUNdrG4OhxOpi59vAGutgqDwfwvmKWq9LtvvxG6 cZsXOKDssfom9g2WGex8YJ8fY7DUhNEXpXQRCAExAKJHLcOcnikwQv5L3ypa9Q8BCi1i iwpwVf0w1mew4cIZ94RkCsU2VHJM+wLgPOT5k7gYEFcD6b5vjz/fqx3yUxjh9VzhMbtT +QST0nTm05mDlRyJFCP6KrRPl1/FZLYhIwbF4ZQQWnI8hjZJwTUNzWMuQvCX013T1oTM k7VkKrm3Zz5Lkb2dxkkgS3RxxiutfUm1h338y7Kr6E3DGeRo0hjxZniUcUbn/9jz41ti 7IgQ== X-Gm-Message-State: AOJu0YxARSAJP0ZBqTnoi47F+WTL4LAXX4emOcF/7PPC+8chF7RvOm8k 6mzVOnIjsAjuBK/nI4OZGSvutma6erlUZEWSMCBZM1hZiW2ZjyfEmHycRSBw6OJRVYXbaFOKaVi FiIabYvA6AncsjRM5ok1WNoUtH3H+PEP3OmGKxJPC X-Gm-Gg: ASbGncv3AouP8xOiU5wAlJ/ATGBqzAypYNXP12VKI8FYGq5WNXlt0aL+EqSu5rr2ZJB Gk0S0UEFc6ZRt+APwamtmHcLsysCbRBYqBlIoH2q1D6xNt7H+ohou4ioGsBUHCkDWMaJa2AoLj6 J3IjAgt64l3X1LgNB6lqZexRwu5F1xI3wpVSoTe63lUyo2XMrx8gaToy7QyrFlwKzSZ5ZtsAmuL mM2mDYF+fbTEe1D56jw29aPOkSN X-Google-Smtp-Source: AGHT+IH0DReH027ruhKw/Kv9nSyiIVnWqE7amCf8nN6sguNNFeX/62aSGzAcwgeFnK8u0L+tp4ghb/ZzGO4iWSW4kjY= X-Received: by 2002:a05:690c:4d42:b0:788:e74:b26b with SMTP id 00721157ae682-78c18164125mr6251007b3.1.1764800948771; Wed, 03 Dec 2025 14:29:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Magnus Hagander Date: Wed, 3 Dec 2025 23:28:55 +0100 X-Gm-Features: AWmQ_bmYDGLeg8YmALe3GStwHwRSm5Wj6aNcW-DhvZd8EeEbcBbKT8xUWN9XlQc Message-ID: Subject: Re: Copy script button cleanup To: Dave Page Cc: PostgreSQL WWW Content-Type: multipart/alternative; boundary="000000000000a6ae04064513bdae" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000a6ae04064513bdae Content-Type: text/plain; charset="UTF-8" On Wed, 3 Dec 2025 at 11:38, Dave Page wrote: > > > On Tue, 2 Dec 2025 at 14:41, Magnus Hagander wrote: > >> >> >> On Tue, 2 Dec 2025 at 12:30, Dave Page wrote: >> >>> The Copy Script buttons on the Linux package installation pages look >>> horrific. See before.png. >>> >>> The attached patch makes them look much nicer, with proper sizing and an >>> icon based button. On click, it briefly changes to a green checkmark to >>> show confirmation. See the after screenshots. >>> >>> I'll apply this in a couple of days if there are no objections. >>> >>> >> LGTM in general and certainly is a lot prettier. >> >> Can you explain what that "fallback for text based buttons" is? Aren't >> they all replaced with icons? >> > > Oh, yeah. That's no longer needed now the patch is complete. I'll remove > it. > > >> >> Oh, and I'm told you're not supposed to use "var" for variables in js due >> to the broken scoping :) >> > > Old habits die hard :-( > > >> >> And while you're poking at it, one thing I've really wanted is a "copy >> without the sudo parts". But I'm guessing that would be a lot more >> complicated than what you're fixing here... >> > > Ask and thou shalt receive. > Sweet! :) 2 patches attached. Both fix the original issue. One also adds the no sudo > button. > > Looks good in a (fairly brief) check. Thanks! -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/ --000000000000a6ae04064513bdae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, 3 Dec 2025 at 11:38, Dave Page &l= t;dpage@pgadmin.org> wrote:


<= div class=3D"gmail_quote">
On Tue, 2 D= ec 2025 at 14:41, Magnus Hagander <magnus@hagander.net> wrote:

On Tue, 2 Dec 2025 at 12:30, Dave Page <dpage@pgadmin.org> wrote:
The Copy Sc= ript buttons on the Linux package installation pages look horrific. See bef= ore.png.

The attached patch makes them look much n= icer, with proper sizing and an icon based button. On click, it briefly cha= nges to a green checkmark to show confirmation. See the after screenshots.<= /div>

I'll apply this in a couple of days if there a= re no objections.


LGTM in general and certainly is a lot prettier.

Can you explain what that "fallback for text based buttons" is?= =C2=A0 Aren't they all replaced with icons?

Oh, yeah. That's no longer needed now the patch = is complete. I'll remove it.
=C2=A0
<= div>
Oh, and I'm told you're not supposed to use &quo= t;var" for variables in js due to the broken scoping :)

Old habits die hard :-(
=C2= =A0

And while you're poking at it, one thing I've = really wanted is a "copy without the sudo parts". But I'm gue= ssing that would be a lot more complicated than what you're fixing here= ...

Ask and thou shalt receive.=

Sweet! :)

=

2 patches attached. Both fix t= he original issue. One also adds the no sudo button.


Looks good in a (fairly brief) c= heck. Thanks!
=C2=A0
--
=C2=A0Magnus Hagander
=C2=A0Me: https://www.hagander.net/
=C2=A0Work: https://www.redpill= -linpro.com/
--000000000000a6ae04064513bdae--