public inbox for [email protected]  
help / color / mirror / Atom feed
Update Commitfest requirements and README
2+ messages / 2 participants
[nested] [flat]

* Update Commitfest requirements and README
@ 2022-01-22 17:34 Andreas 'ads' Scherbaum <[email protected]>
  2022-01-25 17:03 ` Re: Update Commitfest requirements and README Magnus Hagander <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Andreas 'ads' Scherbaum @ 2022-01-22 17:34 UTC (permalink / raw)
  To: [email protected]


Hello,

While trying something out on the Commitfest, I found that the README
and the dependencies are quite outdated. It still requires Django 1.8, 
as example.
And a couple modules are missing, which are not listed in the dependencies.

Attached patch takes a first shot at this problem, updates dependencies and
README to Django 3.2 and adds all missing modules (so far).

This brings the website into a state where it at least starts.
But then when I try to login, I run into this error:

'Settings' object has no attribute 'PGAUTH_REDIRECT'

Apparently the example settings for /local_settings.py/ are incomplete.


Thanks,

-- 
				Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project


Attachments:

  [text/x-patch] pgcommitfest2-1.diff (1.6K, 3-pgcommitfest2-1.diff)
  download | inline diff:
diff --git a/README.md b/README.md
index 0debed2..7dd48bc 100644
--- a/README.md
+++ b/README.md
@@ -6,7 +6,7 @@ A commitfest is a collection of patches and reviews for a project and is part of
 
 ## The Application
 
-This is a Django 1.8 application backed by PostgreSQL and running on Python 2.7.
+This is a Django 3.2 application backed by PostgreSQL and running on Python 3.x.
 
 ## Getting Started
 
@@ -15,7 +15,7 @@ This is a Django 1.8 application backed by PostgreSQL and running on Python 2.7.
 First, prepare your development environment by installing pip, virtualenv, and postgresql-server-dev-X.Y.
 
 ```
-$ sudo apt install python-pip postgresql-server-dev-9.6
+$ sudo apt install python-pip postgresql-server-dev-14
 
 $ pip install virtualenv
 ```
@@ -57,7 +57,7 @@ AUTHENTICATION_BACKENDS = ['django.contrib.auth.backends.ModelBackend']
 ```
 
 Provided that you created a database matching the above settings, you can
-now create the required tables.
+now create the required tables. Note that a password must be provided.
 
 ```
 $ python manage.py migrate
@@ -79,7 +79,8 @@ To authenticate you'll first have to remove the customized login template.
 Remember not to commit this modification.
 
 ```
-$ rm -rf global_templates/admin/login.html
+$ find . -type f -name login.html
+$ rm -f global_templates/admin/login.html
 ```
 
 Then open http://localhost:8000/admin to log in. Once redirected to the Django
diff --git a/requirements.txt b/requirements.txt
index d4d8e3c..5d6adef 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,7 @@
-django>1.8,<1.9
+django>=3.2,<4.0
 psycopg2
 simplejson
 pycrypto
+requests
+pycryptodome
+pycryptodomex


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Update Commitfest requirements and README
  2022-01-22 17:34 Update Commitfest requirements and README Andreas 'ads' Scherbaum <[email protected]>
@ 2022-01-25 17:03 ` Magnus Hagander <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Magnus Hagander @ 2022-01-25 17:03 UTC (permalink / raw)
  To: Andreas 'ads' Scherbaum <[email protected]>; +Cc: [email protected]

On Sat, Jan 22, 2022 at 6:34 PM Andreas 'ads' Scherbaum <[email protected]> wrote:
>
>
> Hello,
>
> While trying something out on the Commitfest, I found that the README
> and the dependencies are quite outdated. It still requires Django 1.8, as example.
> And a couple modules are missing, which are not listed in the dependencies.
>
> Attached patch takes a first shot at this problem, updates dependencies and
> README to Django 3.2 and adds all missing modules (so far).

Yeah, this looks cvorrect. Applied.


> This brings the website into a state where it at least starts.
> But then when I try to login, I run into this error:
>
> 'Settings' object has no attribute 'PGAUTH_REDIRECT'
>
> Apparently the example settings for local_settings.py are incomplete.

yeah. You need to set PGAUTH_REDIRECT and PGAUTH_KEY to have it
integrate with a local pgweb. I think the intention was at some point
to make it usable without that, and just with local accounts, but it
doesn't appear to be -- either that was never done or it has gone
broken over time. I think you can make it work locally by just
commenting out all references to the "pgcommitfest.auth" module from
urls.py?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/






^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-01-25 17:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-01-22 17:34 Update Commitfest requirements and README Andreas 'ads' Scherbaum <[email protected]>
2022-01-25 17:03 ` Magnus Hagander <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox