MIME-Version: 1.0
References: <21fbb020-83c6-33e5-9cfe-0aee56badf3e@cmatte.me>
 <CABUevExDQhiAwL7qAKR1=DFmrFVzb+zHKpfurUo8P78hoATe6A@mail.gmail.com>
 <3ee3217a-b014-7601-47f5-775428d1e39d@cmatte.me>
In-Reply-To: <3ee3217a-b014-7601-47f5-775428d1e39d@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 27 Oct 2021 15:47:59 +0200
Message-ID: 
 <CABUevEw6rNMzaZPooV+WPZ9RTn9af9WLqFD-vR_RCYL56HJapQ@mail.gmail.com>
Subject: Re: [PATCH] pgweb: Search: bugfix: replace sites.baseurl with
 sites.hostname
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>,
	"Jonathan S. Katz" <jkatz@postgresql.org>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000037fce905cf55d873"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEw6rNMzaZPooV%2BWPZ9RTn9af9WLqFD-vR_RCYL56HJapQ%40mail.gmail.com>
Precedence: bulk

--00000000000037fce905cf55d873
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 25, 2021 at 6:19 PM C=C3=A9lestin Matte <celestin.matte@cmatte.=
me>
wrote:

> Hello,
>
> > But short term, I believe the correct thing to do is to add the baseurl
> field to the table in the SQL file. I'll go push a patch taht does that.
>
> This broke data.sql as baseurl is NOT NULL. Attached patch fixes that.
> This might have also broken the crawler but I haven't installed it to tes=
t
> that.
>

Indeed it does. Oops.

That said, most of that file are not-current examples, and should just be
cleaned out, so I'll do that while fixing this.

Yeah, another sign that this needs some proper spring cleaning to get rid
of configuration of the flexibility that we don't care about. But tihs one
for now, to unbreak things short-term.

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--00000000000037fce905cf55d873
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Mon, Oct 25, 2021 at 6:19 PM C=C3=A9le=
stin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.matte@c=
matte.me</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
&gt; But short term, I believe the correct thing to do is to add the baseur=
l field to the table in the SQL file. I&#39;ll go push a patch taht does th=
at.<br>
<br>
This broke data.sql as baseurl is NOT NULL. Attached patch fixes that.<br>
This might have also broken the crawler but I haven&#39;t installed it to t=
est that.<br></blockquote><div><br></div><div>Indeed it does. Oops.</div><d=
iv><br></div><div>That said, most of that file are not-current examples, an=
d should just be cleaned out, so I&#39;ll do that while fixing this.</div><=
div><br></div><div>Yeah, another sign that this needs some proper spring cl=
eaning to get rid of configuration of the flexibility that we don&#39;t car=
e about. But tihs one for now, to unbreak things short-term.</div><div><br>=
</div></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l=
tr"><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a href=3D"http://www.hagander.=
net/" target=3D"_blank">https://www.hagander.net/</a><br>=C2=A0Work: <a hre=
f=3D"http://www.redpill-linpro.com/" target=3D"_blank">https://www.redpill-=
linpro.com/</a></div></div></div></div>

--00000000000037fce905cf55d873--