MIME-Version: 1.0
References: <cbd18681-4bb0-d4d2-50f8-14ed20e1dddf@cmatte.me>
In-Reply-To: <cbd18681-4bb0-d4d2-50f8-14ed20e1dddf@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Thu, 4 Nov 2021 11:29:16 +0100
Message-ID: 
 <CABUevEw9uzwxnVqSTCgOYCYPNy2DbUW7uv7Fj3yk_ntkfpp5jg@mail.gmail.com>
Subject: Re: [PATCHES] pglister: make organization name generic
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000004a7ce305cff40063"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEw9uzwxnVqSTCgOYCYPNy2DbUW7uv7Fj3yk_ntkfpp5jg%40mail.gmail.com>
Precedence: bulk

--0000000000004a7ce305cff40063
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 2, 2021 at 5:18 PM C=C3=A9lestin Matte <celestin.matte@cmatte.m=
e>
wrote:

> Hello,
>
> PGLister is currently made to be run for PostgreSQL only. In an effort to
> get this software used by other organizations, this series of patches
> defines an ORGANIZATION_NAME configuration option and uses it to replace
> mentions of PostreSQL in templates.
> Additionally, new images for the banner are proposed, to replace mentions
> of PostreSQL by a sober "PGLister". Postgres' logo is, however, kept.
>

As a general rule, please post the patches no the thread of the
description, and if it's more than one patch, in the same email. Right now
the only thing I see to review is this description, that's kind of hard.

As for reviewing the general idea, I agree with that -- makes perfect sense
to do that. I did note that Alvaro spotted that it also needs to look over
all the rest of the text and find similar stuff -- like the image alt=3D""
attribute. There may be more of those?

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--0000000000004a7ce305cff40063
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Nov 2, 2021 at 5:18 PM C=C3=
=A9lestin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me" target=3D"_=
blank">celestin.matte@cmatte.me</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">Hello,<br>
<br>
PGLister is currently made to be run for PostgreSQL only. In an effort to g=
et this software used by other organizations, this series of patches define=
s an ORGANIZATION_NAME configuration option and uses it to replace mentions=
 of PostreSQL in templates.<br>
Additionally, new images for the banner are proposed, to replace mentions o=
f PostreSQL by a sober &quot;PGLister&quot;. Postgres&#39; logo is, however=
, kept.<br></blockquote><div><br></div><div>As a general rule, please post =
the patches no the thread of the description, and if it&#39;s more than one=
 patch, in the same email. Right now the only thing I see to review is this=
 description, that&#39;s kind of hard.</div><div><br></div><div>As for revi=
ewing the general idea, I agree with that -- makes perfect sense to do that=
. I did note that Alvaro spotted that it also needs to look over all the re=
st of the text and find similar stuff -- like the image alt=3D&quot;&quot; =
attribute. There may be more of those?</div></div><div><br></div>-- <br><di=
v dir=3D"ltr"><div dir=3D"ltr"><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a h=
ref=3D"http://www.hagander.net/" target=3D"_blank">https://www.hagander.net=
/</a><br>=C2=A0Work: <a href=3D"http://www.redpill-linpro.com/" target=3D"_=
blank">https://www.redpill-linpro.com/</a></div></div></div></div>

--0000000000004a7ce305cff40063--