MIME-Version: 1.0
References: <6945e6fc-0006-454e-079f-f7b91af2be22@cmatte.me>
In-Reply-To: <6945e6fc-0006-454e-079f-f7b91af2be22@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 27 Oct 2021 11:21:37 +0200
Message-ID: 
 <CABUevEwD_qbzgJdZCrFvrfLDM+QVwKW+1RWSkB-xh97Oi+UZ7g@mail.gmail.com>
Subject: Re: [PATCH] pgweb: Add ARCHIVES_FRONT_ADDRESS to allow configuration
 of archives
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000a703b405cf521f81"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEwD_qbzgJdZCrFvrfLDM%2BQVwKW%2B1RWSkB-xh97Oi%2BUZ7g%40mail.gmail.com>
Precedence: bulk

--000000000000a703b405cf521f81
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 26, 2021 at 4:34 PM C=C3=A9lestin Matte <celestin.matte@cmatte.=
me>
wrote:

> Hello,
>
> Domain of messages in pgweb's search is currently hardcoded as
> postgresql.org
> in templates/search/listsearch.html. This patch allows to use another
> domain
> for links to messages in archives in the search function.
> Since pgarchives' domain can differ from pgweb's one, a new variable is
> defined
> for that purpose instead of using SITE_ROOT.
>

This patch adds a new parameter ARCHIVES_FRONT_ADDRESS, which is then never
used. Instead it passes in ARCHIVES_SEARCH_SERVER into the templates.

I'm pretty sure that's not intentional? They should both b
ARCHIVES_FRONT_ADDRESS?

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000a703b405cf521f81
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Oct 26, 2021 at 4:34 PM C=C3=A9le=
stin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.matte@c=
matte.me</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
Domain of messages in pgweb&#39;s search is currently hardcoded as <a href=
=3D"http://postgresql.org" rel=3D"noreferrer" target=3D"_blank">postgresql.=
org</a><br>
in templates/search/listsearch.html. This patch allows to use another domai=
n<br>
for links to messages in archives in the search function.<br>
Since pgarchives&#39; domain can differ from pgweb&#39;s one, a new variabl=
e is defined<br>
for that purpose instead of using SITE_ROOT.<br></blockquote><div><br></div=
><div>This patch adds a new parameter=C2=A0ARCHIVES_FRONT_ADDRESS, which is=
 then never used. Instead it passes in ARCHIVES_SEARCH_SERVER into the temp=
lates.</div><div><br></div><div>I&#39;m pretty sure that&#39;s not intentio=
nal? They should both b ARCHIVES_FRONT_ADDRESS?</div><div><br></div></div>-=
- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>=C2=
=A0Magnus Hagander<br>=C2=A0Me: <a href=3D"http://www.hagander.net/" target=
=3D"_blank">https://www.hagander.net/</a><br>=C2=A0Work: <a href=3D"http://=
www.redpill-linpro.com/" target=3D"_blank">https://www.redpill-linpro.com/<=
/a></div></div></div></div>

--000000000000a703b405cf521f81--