MIME-Version: 1.0
References: <ake43CicUsJNosbi@alvherre.pgsql>
 <CA+OCxowRWHGLQxT7i27PnzsEroFOkkXBSBMEBCnVDU2w1sSD=w@mail.gmail.com>
In-Reply-To: 
 <CA+OCxowRWHGLQxT7i27PnzsEroFOkkXBSBMEBCnVDU2w1sSD=w@mail.gmail.com>
From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 8 Jul 2026 11:45:10 +0200
Message-ID: 
 <CABUevEwgwBQQ1y5Rs+auu-M1wridv42u65nFsxVH4xs_9mjEFg@mail.gmail.com>
Subject: Re: pglister: don't say "subject is empty" for non-empty subjects
To: Dave Page <dpage@pgadmin.org>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	"w^3" <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000f1525f0656165d38"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEwgwBQQ1y5Rs%2Bauu-M1wridv42u65nFsxVH4xs_9mjEFg%40mail.gmail.com>
Precedence: bulk

--000000000000f1525f0656165d38
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 3 Jul 2026 at 15:43, Dave Page <dpage@pgadmin.org> wrote:

>
>
> On Fri, 3 Jul 2026 at 14:30, =C3=81lvaro Herrera <alvherre@kurilemu.de> w=
rote:
>
>> Hi
>>
>> We just got a complaint about a moderation message being unclear -- the
>> moderation interface says that the subject is empty when it isn't.  I
>> propose to reword the message.  Also, the constant name was already
>> wrong, but now it is even more obvious how wrong it is, so update it.
>>
>> Proposed patch attached.
>>
>
> Looks good to me - thanks!
>
>

Looks reasonable. Pushed. Thanks!

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000f1525f0656165d38
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, 3 Jul 2=
026 at 15:43, Dave Page &lt;<a href=3D"mailto:dpage@pgadmin.org">dpage@pgad=
min.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"=
margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-lef=
t:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_=
quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, 3 Jul 2026 at 14:30, =
=C3=81lvaro Herrera &lt;<a href=3D"mailto:alvherre@kurilemu.de" target=3D"_=
blank">alvherre@kurilemu.de</a>&gt; wrote:<br></div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex">Hi<br>
<br>
We just got a complaint about a moderation message being unclear -- the<br>
moderation interface says that the subject is empty when it isn&#39;t.=C2=
=A0 I<br>
propose to reword the message.=C2=A0 Also, the constant name was already<br=
>
wrong, but now it is even more obvious how wrong it is, so update it.<br>
<br>
Proposed patch attached.<br></blockquote><div><br></div><div>Looks good to =
me - thanks!</div><div>=C2=A0</div></div></div></blockquote><div><br></div>=
<div>Looks reasonable. Pushed. Thanks!</div><div>=C2=A0</div></div><span cl=
ass=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmai=
l_signature"><div dir=3D"ltr"><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a hr=
ef=3D"http://www.hagander.net/" target=3D"_blank">https://www.hagander.net/=
</a><br>=C2=A0Work: <a href=3D"http://www.redpill-linpro.com/" target=3D"_b=
lank">https://www.redpill-linpro.com/</a></div></div></div></div>

--000000000000f1525f0656165d38--