MIME-Version: 1.0
References: <d6edac7f-c882-9531-f223-7899e5d93123@cmatte.me>
 <71f7adb0-8588-a695-acad-f7034d3315d4@cmatte.me>
In-Reply-To: <71f7adb0-8588-a695-acad-f7034d3315d4@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Sat, 23 Oct 2021 16:30:43 +0200
Message-ID: 
 <CABUevEwxztRLDWNxBuQmAmFYcRHLsxv-dZ1BHWU4_ZLAy0G1nA@mail.gmail.com>
Subject: Re: [PATCH] pgarchives: Fix database install procedure: remove
 redundant tables in schema.sql
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>,
	"Jonathan S. Katz" <jkatz@postgresql.org>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000aed30b05cf05f947"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEwxztRLDWNxBuQmAmFYcRHLsxv-dZ1BHWU4_ZLAy0G1nA%40mail.gmail.com>
Precedence: bulk

--000000000000aed30b05cf05f947
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 22, 2021 at 5:20 PM C=C3=A9lestin Matte <celestin.matte@cmatte.=
me>
wrote:

> Hello,
>
> Apologies, patch sent in previous email of this thread is incorrect.
> Please find correct patch attached.
>
> In fact, the pgarchives repository is in a weird state, in which the
> migration adding two tables is missing
> (0005_apiclient_threadsubscription.py when running makemigrations). My
> guess is that this is because these tables use SERIALs, which django does
> not handle properly, and must by created using raw SQL. Am I right?
> Is it something that should be fixed?
>

Ugfh, yeah that one is really embarrassing on my part, and I thought I'd
cleaned that one up but clearly not. The whole threadsubscription part
wasn't finished, and was not supposed to be included
in 4d159ca8b4efb0b1cf0893bca63d6e9489a9095f.

The correct solution there is to revert most
of 4d159ca8b4efb0b1cf0893bca63d6e9489a9095f, to have it include only the
parts that are supposed to be there. And then reapply them at some time in
the future when the code is finished. I'll go clean that up -- thanks for
bringing my attention back to that!

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000aed30b05cf05f947
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 22, 2021 at 5:20 PM C=C3=
=A9lestin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.ma=
tte@cmatte.me</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">Hello,<br>
<br>
Apologies, patch sent in previous email of this thread is incorrect. Please=
 find correct patch attached.<br>
<br>
In fact, the pgarchives repository is in a weird state, in which the migrat=
ion adding two tables is missing (0005_apiclient_threadsubscription.py when=
 running makemigrations). My guess is that this is because these tables use=
 SERIALs, which django does not handle properly, and must by created using =
raw SQL. Am I right?<br>
Is it something that should be fixed?<br></blockquote><div><br></div><div>U=
gfh, yeah that one is really embarrassing=C2=A0on my part, and I thought I&=
#39;d cleaned that one up but clearly not. The whole threadsubscription=C2=
=A0part wasn&#39;t finished, and was not supposed to be included in=C2=A04d=
159ca8b4efb0b1cf0893bca63d6e9489a9095f.=C2=A0</div><div><br></div><div>The =
correct solution there is to revert most of=C2=A04d159ca8b4efb0b1cf0893bca6=
3d6e9489a9095f, to have it include only the parts that are supposed to be t=
here. And then reapply them at some time in the future when the code is fin=
ished. I&#39;ll go clean that up -- thanks for bringing my attention back t=
o that!</div><div>=C2=A0</div></div>-- <br><div dir=3D"ltr" class=3D"gmail_=
signature"><div dir=3D"ltr"><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a href=
=3D"http://www.hagander.net/" target=3D"_blank">https://www.hagander.net/</=
a><br>=C2=A0Work: <a href=3D"http://www.redpill-linpro.com/" target=3D"_bla=
nk">https://www.redpill-linpro.com/</a></div></div></div></div>

--000000000000aed30b05cf05f947--