MIME-Version: 1.0
References: <4de7ef7b-cdb3-2d97-5e6a-444e48b192bf@cmatte.me>
In-Reply-To: <4de7ef7b-cdb3-2d97-5e6a-444e48b192bf@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Sun, 31 Oct 2021 15:27:29 +0000
Message-ID: 
 <CABUevEx=CB6Ka1hjmidDUrsQP01QCLq=T+sLiJVTSiCDD+RQ3Q@mail.gmail.com>
Subject: Re: [PATCH] pglister: Add possibility to override settings.py in
 settings_local.py
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000006fc07a05cfa7b3c4"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEx%3DCB6Ka1hjmidDUrsQP01QCLq%3DT%2BsLiJVTSiCDD%2BRQ3Q%40mail.gmail.com>
Precedence: bulk

--0000000000006fc07a05cfa7b3c4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 27, 2021 at 4:02 PM C=C3=A9lestin Matte <celestin.matte@cmatte.=
me>
wrote:

> Following the model of pgweb and pgarchives
>

Hi!

local_settings.py is already ignored in web/pglister/.gitignore -- does
that not work for some reason? It works fine from here.

Second, I'm not sure why we want to exclude local_settings.py from
pycodestyle in general?

And finally, settings.py already contains:
try:
    from .local_settings import *
except ImportError:
    pass


Just a couple of lines above where you are adding it back again. Is that
also for some reason not working?

And it is important that it is included before we do the exim part for
example -- otherwise you cannot control that from within local_settings.py.

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--0000000000006fc07a05cfa7b3c4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 27, 2021 at 4:02 PM C=C3=
=A9lestin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.ma=
tte@cmatte.me</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">Following the model of pgweb and pgarchives<br></blockquote><d=
iv><br></div><div>Hi!</div><div><br></div><div>local_settings.py is already=
 ignored in web/pglister/.gitignore -- does that not work for some reason? =
It works fine from here.</div><div><br></div><div>Second, I&#39;m not sure =
why we want to exclude local_settings.py from pycodestyle in general?</div>=
<div><br></div><div>And finally, settings.py already contains:</div>try:<br=
>=C2=A0 =C2=A0 from .local_settings import *<br>except ImportError:<br>=C2=
=A0 =C2=A0 pass<br><div><br></div><div><br></div><div>Just a couple of line=
s above where you are adding it back again. Is that also for some reason no=
t working?</div><div><br></div><div>And it is important that it is included=
 before we do the exim part for example -- otherwise you cannot control tha=
t from within local_settings.py.</div><div>=C2=A0<br></div></div>-- <br><di=
v dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>=C2=A0Magnus =
Hagander<br>=C2=A0Me: <a href=3D"http://www.hagander.net/" target=3D"_blank=
">https://www.hagander.net/</a><br>=C2=A0Work: <a href=3D"http://www.redpil=
l-linpro.com/" target=3D"_blank">https://www.redpill-linpro.com/</a></div><=
/div></div></div>

--0000000000006fc07a05cfa7b3c4--