MIME-Version: 1.0
References: <4de7ef7b-cdb3-2d97-5e6a-444e48b192bf@cmatte.me>
 <CABUevEx=CB6Ka1hjmidDUrsQP01QCLq=T+sLiJVTSiCDD+RQ3Q@mail.gmail.com>
 <c404df0f-0f6b-f513-fa52-0edc2e569be6@cmatte.me>
In-Reply-To: <c404df0f-0f6b-f513-fa52-0edc2e569be6@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Thu, 4 Nov 2021 11:24:25 +0100
Message-ID: 
 <CABUevExDcZyiHERttpJuWtG3vEKctFbW_V_mod7HL+29cCm6bQ@mail.gmail.com>
Subject: Re: [PATCH] pglister: Add possibility to override settings.py in
 settings_local.py
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000f19cdf05cff3eeb7"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevExDcZyiHERttpJuWtG3vEKctFbW_V_mod7HL%2B29cCm6bQ%40mail.gmail.com>
Precedence: bulk

--000000000000f19cdf05cff3eeb7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 31, 2021 at 7:02 PM C=C3=A9lestin Matte <celestin.matte@cmatte.=
me>
wrote:

> Hello,
>
> >
> > And finally, settings.py already contains:
> > try:
> >     from .local_settings import *
> > except ImportError:
> >     pass
> >
> >
> > Just a couple of lines above where you are adding it back again. Is tha=
t
> also for some reason not working?
>
> Right, I missed that. It's just that in pgweb and pgarchives, the file is
> called settings_local.py, whereas pglister calls it local_settings.py. Th=
is
> is just a question of naming consistency, then. Do you think it's worth
> patching?
>

If anything, we'd want to move to local_settings.py in that case -- the
reason we switched to doing that in a bunch of the other projects is TBH
something as simple as "then tab completion works better".

In general we've said it's not worth breaking compat for it on the old
repos though. That can obviously be argued. But if we do, we definitely
don't want to do *both*, in that case we should remove them.


> > Second, I'm not sure why we want to exclude local_settings.py from
> pycodestyle in general?
>
> It's ignored in pgweb, I just assumed there was a good reason for that an=
d
> did the same thing for consistency.
>

Oh, I wasn't even aware of that. TBH, I'm not sure that's intentional, that
may be a leak from "it was easiest to do that in the beginning".

I don't really see a reason why we wouldn't want that file to be scanned as
well -- do you?

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000f19cdf05cff3eeb7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Sun, Oct 31, 2021 at 7:02 PM C=C3=
=A9lestin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.ma=
tte@cmatte.me</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">Hello,<br>
<br>
&gt; <br>
&gt; And finally, settings.py already contains:<br>
&gt; try:<br>
&gt; =C2=A0 =C2=A0 from .local_settings import *<br>
&gt; except ImportError:<br>
&gt; =C2=A0 =C2=A0 pass<br>
&gt; <br>
&gt; <br>
&gt; Just a couple of lines above where you are adding it back again. Is th=
at also for some reason not working?<br>
<br>
Right, I missed that. It&#39;s just that in pgweb and pgarchives, the file =
is called settings_local.py, whereas pglister calls it local_settings.py. T=
his is just a question of naming consistency, then. Do you think it&#39;s w=
orth patching?<br></blockquote><div><br></div><div>If anything, we&#39;d wa=
nt to move to local_settings.py in that case -- the reason we switched to d=
oing that in a bunch of the other projects is TBH something as simple as &q=
uot;then tab completion works better&quot;.</div><div><br></div><div>In gen=
eral we&#39;ve said it&#39;s not worth breaking compat for it on the old re=
pos though. That can obviously be argued. But if we do, we definitely don&#=
39;t want to do *both*, in that case we should remove them.</div><div><br><=
/div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; Second, I&#39;m not sure why we want to exclude local_settings.py from=
 pycodestyle in general?<br>
<br>
It&#39;s ignored in pgweb, I just assumed there was a good reason for that =
and did the same thing for consistency.<br></blockquote><div><br></div><div=
>Oh, I wasn&#39;t even aware of that. TBH, I&#39;m not sure that&#39;s inte=
ntional, that may be a leak from &quot;it was easiest to do that in the beg=
inning&quot;.</div><div><br></div><div>I don&#39;t really see a reason why =
we wouldn&#39;t want that file to be scanned as well -- do you?=C2=A0</div>=
</div><div><br></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div=
 dir=3D"ltr"><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a href=3D"http://www.=
hagander.net/" target=3D"_blank">https://www.hagander.net/</a><br>=C2=A0Wor=
k: <a href=3D"http://www.redpill-linpro.com/" target=3D"_blank">https://www=
.redpill-linpro.com/</a></div></div></div></div>

--000000000000f19cdf05cff3eeb7--