MIME-Version: 1.0
In-Reply-To: 
 <CABRT9RBbNU17um=DW3VRLE0DW0ahanAo07bNLXsF73F+rhZgQA@mail.gmail.com>
References: 
 <CABRT9RCFpt35TdrrN0jsY3YfqMiiJOTTWYWpSQKYaEdcQZKugw@mail.gmail.com>
	<CABUevEyuu2kJhqjv9kSovuwg99sKf5zYKASXf=3d8ffKnQZ4aA@mail.gmail.com>
	<201205281344.51634.andres@2ndquadrant.com>
	<CABRT9RBbNU17um=DW3VRLE0DW0ahanAo07bNLXsF73F+rhZgQA@mail.gmail.com>
Date: Tue, 5 Jun 2012 10:59:54 +0200
Message-ID: 
 <CABUevExJFVOk4Xz4DVVKHvRAHuw7-23Uog0zsSKhagMbgXcJUA@mail.gmail.com>
Subject: Re: [PATCH] Cross-version navigation in documentation
From: Magnus Hagander <magnus@hagander.net>
To: Marti Raudsepp <marti@juffo.org>
Cc: Andres Freund <andres@2ndquadrant.com>,
	pgsql-www <pgsql-www@postgresql.org>,
	Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Wed, May 30, 2012 at 11:58 AM, Marti Raudsepp <marti@juffo.org> wrote:
> On Mon, May 28, 2012 at 2:44 PM, Andres Freund <andres@2ndquadrant.com> w=
rote:
>> The amount of pages actually having been renamed isn't that big. Marti o=
pened
>> up his version of the docs to me and I browsed along and even between 7.=
4 and
>> 9.1 I had a hard time finding pages where you would expect a link from 7=
.4
>> forwards.
>
> Exactly. And people rely on page names right now anyway -- they find
> the page on Google and then just change the version number in the URL
> and see if it works. Either that, or they will read the wrong version.
> What I'm proposing solves >95% of the cases and I think that is good
> enough.

Given that nobody has objecte,d I'm going to go ahead and do this.

However - should we perhaps just list supported versions? Turns the query i=
nto:
	versions =3D DocPage.objects.filter(file=3Dfullname).extra(where=3D['versi=
on
IN (SELECT tree FROM core_version WHERE
supported)']).order_by('-version').only('version', 'file')

or if we do want to list all versions, we should somehow indicate
which versions are supported and not on this list as well, I think.
But I'm happy to just listed supported versions for now.

Thoughts?


> On Sun, May 27, 2012 at 9:40 PM, Magnus Hagander <magnus@hagander.net> wr=
ote:
>> On Sunday, May 27, 2012, Marti Raudsepp wrote:
>>> PS: Python projects have a nearly universal style of using 4-space
>>> indents (PEP-0008).
>
>> I don't really see the point. If your editor can't be consistent about
>> tabs/spaces, you probably have a bigger problem
>
> Well I need to reconfigure my editor to edit these files.

I'm sure you can instruct it to reconfigure itself once you know it
though ;) (based on pathname or such)

--=20
=A0Magnus Hagander
=A0Me: http://www.hagander.net/
=A0Work: http://www.redpill-linpro.com/