MIME-Version: 1.0
References: <c12954dd-c19c-f809-f92c-116469c9543f@cmatte.me>
In-Reply-To: <c12954dd-c19c-f809-f92c-116469c9543f@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Thu, 4 Nov 2021 11:31:33 +0100
Message-ID: 
 <CABUevExbE==POwr9LOESmJ-J+PvkCQ=-F6wH=1SegFUAzxfsCA@mail.gmail.com>
Subject: Re: [PATCH] pgarchives: parser: handle messages in which Message-ID
 is missing
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: pgsql-www@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000007adea605cff4084a"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevExbE%3D%3DPOwr9LOESmJ-J%2BPvkCQ%3D-F6wH%3D1SegFUAzxfsCA%40mail.gmail.com>
Precedence: bulk

--0000000000007adea605cff4084a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 3, 2021 at 6:02 PM C=C3=A9lestin Matte <celestin.matte@cmatte.m=
e>
wrote:

> Hello,
>
> As surprising as it may seem, Message-ID is actually not a mandatory emai=
l
> field [1]. While most MTAs do add this field, some might not, and this wi=
ll
> cause load_message.py to crash.
> As a solution to this, when this field is missing, this patch:
> - attempts to find a "Sent-Message-ID" header and use it as the Message-I=
D
> (a case I encountered when trying to import an old mbox)
> - generates a new Message-ID if none exists, following (a simpler version
> of) [2].
>

I don't think this should be the responsibility of pglister. As you say,
"most MTAs do add this field" -- and the solution is to configure the MTA
to do this. We already rely on the MTA to get a lot of other important
things right.

It may be something that should get documented somewhere as a requirement.

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--0000000000007adea605cff4084a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Nov 3, 2021 at 6:02 PM C=C3=
=A9lestin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.ma=
tte@cmatte.me</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">Hello,<br>
<br>
As surprising as it may seem, Message-ID is actually not a mandatory email =
field [1]. While most MTAs do add this field, some might not, and this will=
 cause load_message.py to crash.<br>
As a solution to this, when this field is missing, this patch:<br>
- attempts to find a &quot;Sent-Message-ID&quot; header and use it as the M=
essage-ID (a case I encountered when trying to import an old mbox)<br>
- generates a new Message-ID if none exists, following (a simpler version o=
f) [2].<br></blockquote><div><br></div><div>I don&#39;t think this should b=
e the responsibility of pglister. As you say, &quot;most MTAs do add this f=
ield&quot; -- and the solution is to configure the MTA to do this. We alrea=
dy rely on the MTA to get a lot of other important things right.</div><div>=
<br></div><div>It may be something that should get documented somewhere as =
a requirement.=C2=A0</div></div><div><br></div>-- <br><div dir=3D"ltr" clas=
s=3D"gmail_signature"><div dir=3D"ltr"><div>=C2=A0Magnus Hagander<br>=C2=A0=
Me: <a href=3D"http://www.hagander.net/" target=3D"_blank">https://www.haga=
nder.net/</a><br>=C2=A0Work: <a href=3D"http://www.redpill-linpro.com/" tar=
get=3D"_blank">https://www.redpill-linpro.com/</a></div></div></div></div>

--0000000000007adea605cff4084a--