MIME-Version: 1.0
References: <5fb488f9-999c-e41f-356b-edcf258d6424@cmatte.me>
In-Reply-To: <5fb488f9-999c-e41f-356b-edcf258d6424@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Sat, 15 Jan 2022 18:54:20 +0100
Message-ID: 
 <CABUevExckBnyw1cUvioswExNrR8cnyM_U12HnWMbvcGTWxYVdg@mail.gmail.com>
Subject: Re: [PATCH 1/2] pgarchives: Add missing authentication backend to
 settings.py
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevExckBnyw1cUvioswExNrR8cnyM_U12HnWMbvcGTWxYVdg%40mail.gmail.com>
Precedence: bulk

On Thu, Oct 28, 2021 at 7:42 PM C=C3=A9lestin Matte <celestin.matte@cmatte.=
me> wrote:
>
> Hello,
>
> Authentication when using private archives in pgarchives is broken with c=
urrent settings.py file.
> This first patch add a missing backend in settings.py, without which sess=
ions aren't registered and users get redirected indefinitely.
> In the second patch of this series, I add missing parameters for configur=
ing PGAUTH, copying the ones from pglister.

Yeah, technically it's configured to use django auth but then we
override that elsewhere.  It might be worthwhile to remove those
hardcoded redirects and make it possible to use the system with the
built in django auth. But until someone does that, I agree that
putting a working value into AUTHENTICATION_BACKEND is definitely
better.

And also the example file that was in your patch #2.

Both patches squashed and applied. Thanks!

--=20
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/