MIME-Version: 1.0
References: 
 <CA+OCxoxH75C4Q79bOfxpwXJtgZxjgTtR1xa+cWL0NVBNnT_OyA@mail.gmail.com>
In-Reply-To: 
 <CA+OCxoxH75C4Q79bOfxpwXJtgZxjgTtR1xa+cWL0NVBNnT_OyA@mail.gmail.com>
From: Magnus Hagander <magnus@hagander.net>
Date: Tue, 2 Dec 2025 15:41:07 +0100
Message-ID: 
 <CABUevExmHVYwddKvFUWkjY8Ev-xAE2p0-mP0wJqJDs1bazMn7A@mail.gmail.com>
Subject: Re: Copy script button cleanup
To: Dave Page <dpage@pgadmin.org>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000cafca40644f91679"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevExmHVYwddKvFUWkjY8Ev-xAE2p0-mP0wJqJDs1bazMn7A%40mail.gmail.com>
Precedence: bulk

--000000000000cafca40644f91679
Content-Type: text/plain; charset="UTF-8"

On Tue, 2 Dec 2025 at 12:30, Dave Page <dpage@pgadmin.org> wrote:

> The Copy Script buttons on the Linux package installation pages look
> horrific. See before.png.
>
> The attached patch makes them look much nicer, with proper sizing and an
> icon based button. On click, it briefly changes to a green checkmark to
> show confirmation. See the after screenshots.
>
> I'll apply this in a couple of days if there are no objections.
>
>
LGTM in general and certainly is a lot prettier.

Can you explain what that "fallback for text based buttons" is?  Aren't
they all replaced with icons?

Oh, and I'm told you're not supposed to use "var" for variables in js due
to the broken scoping :)

And while you're poking at it, one thing I've really wanted is a "copy
without the sudo parts". But I'm guessing that would be a lot more
complicated than what you're fixing here...

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000cafca40644f91679
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, 2 Dec 2=
025 at 12:30, Dave Page &lt;<a href=3D"mailto:dpage@pgadmin.org">dpage@pgad=
min.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"=
margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-lef=
t:1ex"><div dir=3D"ltr"><div>The Copy Script buttons on the Linux package i=
nstallation pages look horrific. See before.png.</div><div><br></div><div>T=
he attached patch makes them look much nicer, with proper sizing and an ico=
n based button. On click, it briefly changes to a green checkmark to show c=
onfirmation. See the after screenshots.</div><div><br></div><div>I&#39;ll a=
pply this in a couple of days if there are no objections.</div><div><br></d=
iv></div></blockquote><div><br></div><div>LGTM in general and certainly is =
a lot prettier.</div><div><br></div><div>Can you explain what that &quot;fa=
llback for text based buttons&quot; is?=C2=A0 Aren&#39;t they all replaced =
with icons?</div><div><br></div><div>Oh, and I&#39;m told you&#39;re not su=
pposed to use &quot;var&quot; for variables in js due to the broken scoping=
 :)</div></div><div><br></div><div>And while you&#39;re poking at it, one t=
hing I&#39;ve really wanted is a &quot;copy without the sudo parts&quot;. B=
ut I&#39;m guessing that would be a lot more complicated than what you&#39;=
re fixing here...</div><div><br></div><span class=3D"gmail_signature_prefix=
">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"=
><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a href=3D"http://www.hagander.net=
/" target=3D"_blank">https://www.hagander.net/</a><br>=C2=A0Work: <a href=
=3D"http://www.redpill-linpro.com/" target=3D"_blank">https://www.redpill-l=
inpro.com/</a></div></div></div></div>

--000000000000cafca40644f91679--