MIME-Version: 1.0
References: <A0228704-7C47-44B8-929B-8BFC02D6CBD7@yesql.se>
In-Reply-To: <A0228704-7C47-44B8-929B-8BFC02D6CBD7@yesql.se>
From: Magnus Hagander <magnus@hagander.net>
Date: Sun, 10 Oct 2021 23:27:52 +0200
Message-ID: 
 <CABUevEy0=L7bomr+_G19FOL7bfSy8NpkzDiRKWupkaSRx7peJg@mail.gmail.com>
Subject: Re: Removing deprecated HTML from the security page
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000002ff14c05ce064ac8"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEy0%3DL7bomr%2B_G19FOL7bfSy8NpkzDiRKWupkaSRx7peJg%40mail.gmail.com>
Precedence: bulk

--0000000000002ff14c05ce064ac8
Content-Type: text/plain; charset="UTF-8"

On Fri, Oct 8, 2021 at 3:48 PM Daniel Gustafsson <daniel@yesql.se> wrote:

> I noticed that our security page use two deprecated constructs, the <nobr>
> tag
> (which also isn't allowed in <td> context) and the name attribute on <a>.
> The
> attached replaces the former with CSS and the latter with the recommended
> ID
> tag.
>

LGTM.

For 0001 I would consider maybe using a name for what it is ("cve-number")
rather than what it does ("nobr"), in case we want to add on more
formatting on it later. But it's such a trivial case that it probably
doesn't matter until we actually have some such special formatting to add.


-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--0000000000002ff14c05ce064ac8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Oct 8, 2021 at 3:48 PM Daniel Gus=
tafsson &lt;<a href=3D"mailto:daniel@yesql.se">daniel@yesql.se</a>&gt; wrot=
e:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex">I noticed that our security page use two deprecated construct=
s, the &lt;nobr&gt; tag<br>
(which also isn&#39;t allowed in &lt;td&gt; context) and the name attribute=
 on &lt;a&gt;.=C2=A0 The<br>
attached replaces the former with CSS and the latter with the recommended I=
D<br>
tag.<br></blockquote><div><br></div><div>LGTM.</div><div><br></div><div>For=
 0001 I would consider maybe using a name for what it is (&quot;cve-number&=
quot;) rather than what it does (&quot;nobr&quot;), in case we want to add =
on more formatting on it later. But it&#39;s such a trivial case that it pr=
obably doesn&#39;t matter until we actually have some such special formatti=
ng to add.</div><div>=C2=A0</div></div><div><br></div>-- <br><div dir=3D"lt=
r" class=3D"gmail_signature"><div dir=3D"ltr"><div>=C2=A0Magnus Hagander<br=
>=C2=A0Me: <a href=3D"http://www.hagander.net/" target=3D"_blank">https://w=
ww.hagander.net/</a><br>=C2=A0Work: <a href=3D"http://www.redpill-linpro.co=
m/" target=3D"_blank">https://www.redpill-linpro.com/</a></div></div></div>=
</div>

--0000000000002ff14c05ce064ac8--