MIME-Version: 1.0
References: <a06e51d0-a7ec-741a-8d93-780011b53cec@cmatte.me>
 <0d7d2e12-bdf9-8b7b-4b90-8380eeef7c16@postgresql.org>
 <CABUevEw+gtEVa1sq0H5FMXuYnm1EXU6mxaqLaYn42tindmCAyQ@mail.gmail.com>
 <0c0f0cff-513a-e2e5-8ff7-a8f1463e364d@cmatte.me>
In-Reply-To: <0c0f0cff-513a-e2e5-8ff7-a8f1463e364d@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 19 Jan 2022 23:30:08 +0100
Message-ID: 
 <CABUevEy0y4vM77A_hbn8YXA6DpLx7dtbvsT+D_13gASbJNjizg@mail.gmail.com>
Subject: Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEy0y4vM77A_hbn8YXA6DpLx7dtbvsT%2BD_13gASbJNjizg%40mail.gmail.com>
Precedence: bulk

On Wed, Jan 19, 2022 at 3:30 PM C=C3=A9lestin Matte <celestin.matte@cmatte.=
me> wrote:
>
> Hi,
>
> I'm reviewing the patches I sent a few months ago and this short one seem=
s to have been left mid-discussion.
>
> > I think having a default like in this patch is better. Otherwise it cou=
ld randomly connect to a database with the same name as the user for exampl=
e, which might actually happen in dev scenarios. So if we want it empty we'=
d also need to add code to check if it's set or not before trying to use it=
 - seems easier to set the default and have it fail :)
>
> I guess it's OK as-is, then?

Yeah, indeed that was forgotten.

Patch now conflicted with your own patch for archives frontend
address. I adjusted it for that and applied. Thanks!


--=20
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/