MIME-Version: 1.0
References: <20190227232603.GA3137@alvherre.pgsql>
 <15210.1551311101@sss.pgh.pa.us>
In-Reply-To: <15210.1551311101@sss.pgh.pa.us>
From: Magnus Hagander <magnus@hagander.net>
Date: Thu, 28 Feb 2019 12:24:45 +0100
Message-ID: 
 <CABUevEy5VMviknBwYC3qBZt7H28=Fkn_Fhg6Ka6ZujpukD+cUw@mail.gmail.com>
Subject: Re: CF app: "target version" entered twice?
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 "w^3" <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000003433730582f28a90"
Precedence: bulk

--0000000000003433730582f28a90
Content-Type: text/plain; charset="UTF-8"

On Thu, Feb 28, 2019 at 12:45 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > I just created a new patch in the commitfest app
> > (https://commitfest.postgresql.org/22/new/).  The app asked me on the
> > first page for the target version ... and then again on the second page.
> > And it didn't remember what I selected first.
>
> Yeah, I noticed the same a couple days ago.
>
> > I suppose the fix is just to remove the "target version" selectable on
> > the first page?
>
> Seems like the path of least resistance.  I'm not sure this is so
> important it has to be on the first page, anyway.
>

That wasn't even intentional :) The form had a list of "include all fields
except x,y,z" so when the field was added it was automatically added there,
and I missed it. I've now switched it to instead list the *included* fields
so this won't happen again -- and it's easier to list 2 included fields
than 12 excluded ones.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--0000000000003433730582f28a90
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, Feb 28, 2019 at 12:45 AM Tom Lane=
 &lt;<a href=3D"mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>&gt; wrote:<=
br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">Alvaro Herrera &lt;<a href=3D"mailto:alvherre@alvh.no-ip.org" ta=
rget=3D"_blank">alvherre@alvh.no-ip.org</a>&gt; writes:<br>
&gt; I just created a new patch in the commitfest app<br>
&gt; (<a href=3D"https://commitfest.postgresql.org/22/new/" rel=3D"noreferr=
er" target=3D"_blank">https://commitfest.postgresql.org/22/new/</a>).=C2=A0=
 The app asked me on the<br>
&gt; first page for the target version ... and then again on the second pag=
e.<br>
&gt; And it didn&#39;t remember what I selected first.<br>
<br>
Yeah, I noticed the same a couple days ago.<br>
<br>
&gt; I suppose the fix is just to remove the &quot;target version&quot; sel=
ectable on<br>
&gt; the first page?<br>
<br>
Seems like the path of least resistance.=C2=A0 I&#39;m not sure this is so<=
br>
important it has to be on the first page, anyway.<br></blockquote><div><br>=
</div><div>That wasn&#39;t even intentional :) The form had a list of &quot=
;include all fields except x,y,z&quot; so when the field was added it was a=
utomatically added there, and I missed it. I&#39;ve now switched it to inst=
ead list the *included* fields so this won&#39;t happen again -- and it&#39=
;s easier to list 2 included fields than 12 excluded ones.=C2=A0</div></div=
><div><br></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=
=3D"ltr"><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a href=3D"http://www.haga=
nder.net/" target=3D"_blank">https://www.hagander.net/</a><br>=C2=A0Work: <=
a href=3D"http://www.redpill-linpro.com/" target=3D"_blank">https://www.red=
pill-linpro.com/</a></div></div></div></div>

--0000000000003433730582f28a90--