public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Célestin Matte <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] pgweb: Add ARCHIVES_FRONT_ADDRESS to allow configuration of archives
Date: Sat, 15 Jan 2022 18:38:52 +0100
Message-ID: <CABUevEyFhSzPWT86DVP10Nst14sqKVT0i31fMB69T6n_dTR0-g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CABUevEwD_qbzgJdZCrFvrfLDM+QVwKW+1RWSkB-xh97Oi+UZ7g@mail.gmail.com>
	<[email protected]>

On Wed, Oct 27, 2021 at 11:45 AM Célestin Matte
<[email protected]> wrote:
>
> > This patch adds a new parameter ARCHIVES_FRONT_ADDRESS, which is then never used. Instead it passes in ARCHIVES_SEARCH_SERVER into the templates.
> >
> > I'm pretty sure that's not intentional? They should both b ARCHIVES_FRONT_ADDRESS?
>
> Oops, indeed, this is the product of a failed git merge --squash.
>
> Fixed patch attached.

Finally cycling back to this one, sorry about the long delay. This
does look much better, applied with th modification that it should
take the whole URL and not just the hostname -- which maks it work
better in development for example.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] pgweb: Add ARCHIVES_FRONT_ADDRESS to allow configuration of archives
  In-Reply-To: <CABUevEyFhSzPWT86DVP10Nst14sqKVT0i31fMB69T6n_dTR0-g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox