MIME-Version: 1.0
References: <20211107164951.wxcyp7iar2s4mjkn@nixos>
 <CABUevEz5X8qSCNEveNOU19Gy3FcOXdRgpP=Z33KUbDw=DNs_cA@mail.gmail.com>
 <20211109225734.7evav44x7nf5c5jb@nixos>
In-Reply-To: <20211109225734.7evav44x7nf5c5jb@nixos>
From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 24 Nov 2021 14:56:03 +0100
Message-ID: 
 <CABUevEyR-jfGWquPTCNpBiw+O_tmHT1xi+9HbYJuXFqjwzu_dQ@mail.gmail.com>
Subject: Re: [PATCH] Improve portability of pgweb/load_initial_data.sh
To: Nils Andre <nils@nilsand.re>
Cc: pgsql-www@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000a3a10005d1893829"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEyR-jfGWquPTCNpBiw%2BO_tmHT1xi%2B9HbYJuXFqjwzu_dQ%40mail.gmail.com>
Precedence: bulk

--000000000000a3a10005d1893829
Content-Type: text/plain; charset="UTF-8"

On Tue, Nov 9, 2021 at 11:57 PM Nils Andre <nils@nilsand.re> wrote:

> Hi,
>
> On Mon, Nov 08, 2021 at 10:03:50AM +0100, Magnus Hagander wrote:
> > Yeah, I think the fact that it says bash is just a "knee-jerk default"
> and
> > not that it ever did either. So I have no problem changing that to sh.
> I'm
> > a bit curious though, as to in which scenario this actually causes a
> > problem?
>
> This causes problems on [NixOS][1] which only has `/bin/sh` and
> `/usr/bin/env` in the location one would "expect" them.
>

Hmm. Interesting. Anyway, this part seems perfectly fine to fix.


> The second change I'm less sure about. There are many different things you
> > could change to break a script. This is one of them. You could change
> PATH,
> > or you could replace "find" or "xargs" with commands that don't work the
> > same way. CDPATH is not a variable that should, I believe, ever be
> exported
> > into non-interactive scripts in the first place.
>
> I didn't realise I was exporting CDPATH, which is ~~probably~~ a mistake
> (and would have prevented previous painful and long headaches).
>

I'm pretty sure that one will break a lot of other things...


For what it's worth, I use a program I have written that makes use of
> CDPATH (and hence requires it to be exported (but I think I will
> reconsider the program's usage of CDPATH)).
>

I would recommend that :)


However I do understand this is an issue with my particular setup.
>
> Attached, is the patch amended without the CDPATH change.
>
>
Thanks, applied as such!

//Magnus

--000000000000a3a10005d1893829
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Nov 9, 2021 at 11:57 PM Nils Andr=
e &lt;<a href=3D"mailto:nils@nilsand.re">nils@nilsand.re</a>&gt; wrote:<br>=
</div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D=
"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-le=
ft:1ex">Hi,<br>
<br>
On Mon, Nov 08, 2021 at 10:03:50AM +0100, Magnus Hagander wrote:<br>
&gt; Yeah, I think the fact that it says bash is just a &quot;knee-jerk def=
ault&quot; and<br>
&gt; not that it ever did either. So I have no problem changing that to sh.=
 I&#39;m<br>
&gt; a bit curious though, as to in which scenario this actually causes a<b=
r>
&gt; problem?<br>
<br>
This causes problems on [NixOS][1] which only has `/bin/sh` and<br>
`/usr/bin/env` in the location one would &quot;expect&quot; them.<br></bloc=
kquote><div><br></div><div>Hmm. Interesting. Anyway, this part seems perfec=
tly fine to fix.=C2=A0</div><div><br></div><div><br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">
&gt; The second change I&#39;m less sure about. There are many different th=
ings you<br>
&gt; could change to break a script. This is one of them. You could change =
PATH,<br>
&gt; or you could replace &quot;find&quot; or &quot;xargs&quot; with comman=
ds that don&#39;t work the<br>
&gt; same way. CDPATH is not a variable that should, I believe, ever be exp=
orted<br>
&gt; into non-interactive scripts in the first place.<br>
<br>
I didn&#39;t realise I was exporting CDPATH, which is ~~probably~~ a mistak=
e<br>
(and would have prevented previous painful and long headaches).<br></blockq=
uote><div><br></div><div>I&#39;m pretty sure that one will break a lot of o=
ther things...=C2=A0</div><div><br></div><div><br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">
For what it&#39;s worth, I use a program I have written that makes use of<b=
r>
CDPATH (and hence requires it to be exported (but I think I will<br>
reconsider the program&#39;s usage of CDPATH)).<br></blockquote><div><br></=
div><div>I would recommend that :)</div><div><br></div><div><br></div><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:=
1px solid rgb(204,204,204);padding-left:1ex">
However I do understand this is an issue with my particular setup.<br>
<br>
Attached, is the patch amended without the CDPATH change.<br><br></blockquo=
te><div><br></div><div>Thanks, applied as such!</div><div><br></div><div>//=
Magnus</div><div>=C2=A0</div></div><div dir=3D"ltr" class=3D"gmail_signatur=
e"><div dir=3D"ltr"></div></div></div>

--000000000000a3a10005d1893829--