MIME-Version: 1.0
References: <d6edac7f-c882-9531-f223-7899e5d93123@cmatte.me>
In-Reply-To: <d6edac7f-c882-9531-f223-7899e5d93123@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Sat, 23 Oct 2021 16:16:13 +0200
Message-ID: 
 <CABUevEy_i1xAKscMv4KZ0=bE8050bBcQfWaNyjwZZBofZx7JgQ@mail.gmail.com>
Subject: Re: [PATCH] pgarchives: Fix database install procedure: remove
 redundant tables in schema.sql
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000da371805cf05c50c"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEy_i1xAKscMv4KZ0%3DbE8050bBcQfWaNyjwZZBofZx7JgQ%40mail.gmail.com>
Precedence: bulk

--000000000000da371805cf05c50c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 18, 2021 at 6:19 PM C=C3=A9lestin Matte <celestin.matte@cmatte.=
me>
wrote:

> Hello,
>
> While installing pgarchives, I've encountered issues that are addressed i=
n
> this patch.
> Django's model and schema.sql both contain tables that are necessary for
> the execution of the application, but are mutually exclusive.
> This is due to some fields in the "messages" table that cannot be defined
> in
> django, and definition of tables in schema.sql that are already created
> by django.
>

Ugh, yeah that is clearly a mess. I thought we had cleaned that up at some
point, but clearly we haven't, and tracking changse has been inconsistent.

I think the correct solution to the problem is to actually get rid of
loader/sql/schema.sql and move it all into the django migrations. Trying to
keep track of half in one place and half in another is just going to lead
to more problems down the road.

So your removal of messages there is a good start, but adding some columns
back after the fact in a different file is a big ugh. We should just make
all that happen in 0001_initial.py.


Additionally, I have two questions:
> - Where is the "tsparser" parser defined? (See commit e05f813b of
> pgarchives).
> It is used in schema.sql, but I haven't found its definition in the
> pgarchives, pglister or pgweb repositories. Is it an alias to
> pg_catalog.pg_ts_parser?
>

It's this one over here: https://github.com/postgrespro/pg_tsparser


> (I have been able to complete the install procedure by reverting e05f813b=
,
> but I have no idea what the consequences are for the application)
> - Same question for /usr/share/postgresql/12/tsearch_data/pg_dict.stop
> I've found pg_dict.syn in pgweb, but not this file.
>

This is just a textfile with stop words. interestingly enough the prod
version for the archives just has the word "sql" in it -- I think there was
a great big plan to do somethign good with that, that turned out to never
happen.


--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000da371805cf05c50c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Oct 18, 2021 at 6:19 PM C=C3=
=A9lestin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.ma=
tte@cmatte.me</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">Hello,<br>
<br>
While installing pgarchives, I&#39;ve encountered issues that are addressed=
 in this patch.<br>
Django&#39;s model and schema.sql both contain tables that are necessary fo=
r<br>
the execution of the application, but are mutually exclusive.<br>
This is due to some fields in the &quot;messages&quot; table that cannot be=
 defined in<br>
django, and definition of tables in schema.sql that are already created<br>
by django.<br></blockquote><div><br></div><div>Ugh, yeah that is clearly a =
mess. I thought we had cleaned that up at some point, but clearly we haven&=
#39;t, and tracking changse has been inconsistent.</div><div><br></div><div=
>I think the correct solution to the problem is to actually get rid of load=
er/sql/schema.sql and move it all into the django migrations. Trying to kee=
p track of half in one place and half in another is just going to lead to m=
ore problems down the road.</div><div><br></div><div>So your removal of mes=
sages there is a good start, but adding some columns back after the fact in=
 a different file is a big ugh. We should just make all that happen in 0001=
_initial.py.</div><div><br></div><div><br></div><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex">
Additionally, I have two questions:<br>
- Where is the &quot;tsparser&quot; parser defined? (See commit e05f813b of=
 pgarchives).<br>
It is used in schema.sql, but I haven&#39;t found its definition in the<br>
pgarchives, pglister or pgweb repositories. Is it an alias to<br>
pg_catalog.pg_ts_parser?<br></blockquote><div><br></div><div>It&#39;s this =
one over here:=C2=A0<a href=3D"https://github.com/postgrespro/pg_tsparser">=
https://github.com/postgrespro/pg_tsparser</a></div><div><br></div><div>=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">
(I have been able to complete the install procedure by reverting e05f813b,<=
br>
but I have no idea what the consequences are for the application)<br>
- Same question for /usr/share/postgresql/12/tsearch_data/pg_dict.stop<br>
I&#39;ve found pg_dict.syn in pgweb, but not this file.<br></blockquote><di=
v><br></div><div>This is just a textfile with stop words. interestingly eno=
ugh the prod version for the archives just has the word &quot;sql&quot; in =
it -- I think there was a great big plan to do somethign good with that, th=
at turned out to never happen.</div><div>=C2=A0</div></div><div><br></div>-=
- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>=C2=
=A0Magnus Hagander<br>=C2=A0Me: <a href=3D"http://www.hagander.net/" target=
=3D"_blank">https://www.hagander.net/</a><br>=C2=A0Work: <a href=3D"http://=
www.redpill-linpro.com/" target=3D"_blank">https://www.redpill-linpro.com/<=
/a></div></div></div></div>

--000000000000da371805cf05c50c--