MIME-Version: 1.0
References: <4280598e-cbe7-c5d3-fbce-fefce11da5f3@cmatte.me>
 <723b45bd-0c14-83eb-1911-b4f481e1b74c@cmatte.me>
 <CABUevEyFpYPEHh0AAyTAsgymRKOOVA1SY_pDHPCbBQQ9BawfTA@mail.gmail.com>
 <a99c5ed6-0e05-2a0c-bef0-4bbb3e04898b@cmatte.me>
In-Reply-To: <a99c5ed6-0e05-2a0c-bef0-4bbb3e04898b@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 27 Oct 2021 15:50:08 +0200
Message-ID: 
 <CABUevEz5VqyjTN9p684n0Zr++V_DbRHtoNE1TY0h6Nsewi-YPQ@mail.gmail.com>
Subject: Re: [PATCH] pgarchives: Bugfix: allow message's parentid to be null
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000f5374b05cf55df68"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEz5VqyjTN9p684n0Zr%2B%2BV_DbRHtoNE1TY0h6Nsewi-YPQ%40mail.gmail.com>
Precedence: bulk

--000000000000f5374b05cf55df68
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 27, 2021 at 12:04 PM C=C3=A9lestin Matte <celestin.matte@cmatte=
.me>
wrote:

> >
> > That said, I think the correct solutoin is still, as I mentioned in one
> of the other threads, to completely move everything into the initial
> migration, instead of doing a piecemeal hack that's going to result in a
> lot of small migrations for no real reason. We should  just accept that t=
he
> existing one is broken and replace it.
>
> Can everything be moved to django's model though? The schema.sql file
> defines several other components (indexes, text search configurations, te=
xt
> search dictionaries, functions, triggers) and I'm not sure django is able
> to handle all of that by itself. Is it? Or do you only want to move table=
s?
>

The models can't handle them, but migrations can.

I'm thinking similar to pglister, where we use django models to create the
parts that *can* be created, and then RunSQL() migrations to do the rest.
That way the pure SQL parts can still run as part of the same flow, and can
be mixed in with the django generated ones. The end result in the database
should be the same, but avoiding to have to maintain a separate .sql file
for it to keep in sync.

I suggest moving everything, for that reason -- to ensure the order of
application.

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000f5374b05cf55df68
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Wed, Oct 27, 2021 at 12:04 PM C=C3=A9l=
estin Matte &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.matte@=
cmatte.me</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid=
 rgb(204,204,204);padding-left:1ex">&gt; <br>
&gt; That said, I think the correct solutoin is still, as I mentioned in on=
e of the other threads, to completely move everything into the initial migr=
ation, instead of doing a piecemeal=C2=A0hack that&#39;s going to result in=
 a lot of small migrations for no real reason. We should=C2=A0 just accept =
that the existing one is broken and replace it.<br>
<br>
Can everything be moved to django&#39;s model though? The schema.sql file d=
efines several other components (indexes, text search configurations, text =
search dictionaries, functions, triggers) and I&#39;m not sure django is ab=
le to handle all of that by itself. Is it? Or do you only want to move tabl=
es?<br></blockquote><div><br></div><div>The models can&#39;t handle them, b=
ut migrations can.</div><div><br></div><div>I&#39;m thinking similar to pgl=
ister, where we use django models to create the parts that *can* be created=
, and then RunSQL() migrations to do the rest. That way the pure SQL parts =
can still run as part of the same flow, and can be mixed in with the django=
 generated ones. The end result in the database should be the same, but avo=
iding to have to maintain a separate .sql file for it to keep in sync.=C2=
=A0</div></div><div><br></div>I suggest moving everything, for that reason =
-- to ensure the order of application.<br clear=3D"all"><div><br></div>-- <=
br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>=C2=A0M=
agnus Hagander<br>=C2=A0Me: <a href=3D"http://www.hagander.net/" target=3D"=
_blank">https://www.hagander.net/</a><br>=C2=A0Work: <a href=3D"http://www.=
redpill-linpro.com/" target=3D"_blank">https://www.redpill-linpro.com/</a><=
/div></div></div></div>

--000000000000f5374b05cf55df68--