MIME-Version: 1.0
References: <cbd18681-4bb0-d4d2-50f8-14ed20e1dddf@cmatte.me>
 <CABUevEw9uzwxnVqSTCgOYCYPNy2DbUW7uv7Fj3yk_ntkfpp5jg@mail.gmail.com>
 <a37e411a-d387-2202-2d98-6b4d68326247@cmatte.me>
In-Reply-To: <a37e411a-d387-2202-2d98-6b4d68326247@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Sat, 15 Jan 2022 19:06:35 +0100
Message-ID: 
 <CABUevEzBBjh7Ha9dXT4AU+0s4GmBR9sYjqXbcK_aULn=mqqY0A@mail.gmail.com>
Subject: Re: [PATCHES] pglister: make organization name generic
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEzBBjh7Ha9dXT4AU%2B0s4GmBR9sYjqXbcK_aULn%3DmqqY0A%40mail.gmail.com>
Precedence: bulk

On Thu, Nov 4, 2021 at 12:21 PM C=C3=A9lestin Matte <celestin.matte@cmatte.=
me> wrote:
>
> > As a general rule, please post the patches no the thread of the descrip=
tion, and if it's more than one patch, in the same email. Right now the onl=
y thing I see to review is this description, that's kind of hard.
>
> Sorry, I don't understand: should I send all patches by responding to the=
 description email (instead of replying to the previous ones, as I did here=
), or all patches in the same email?

All in the same email is definitely best, like you did in this one -- thank=
s!

> > As for reviewing the general idea, I agree with that -- makes perfect s=
ense to do that. I did note that Alvaro spotted that it also needs to look =
over all the rest of the text and find similar stuff -- like the image alt=
=3D"" attribute. There may be more of those?
>
> Yep, added handling of ORGANIZATION_MOTTO in the set of patches attached =
to this email.

Looking at 1 and 2, this just seems to me like a strange way to do it,
by declaring a new tag for it.

I think it would be cleaner with a Context Processor similar to what
we have in pgweb. Then this context processor could just return a dict
of ORGANIZATION_INFO from setitngs.py, wihch would have a key for name
and a key for motto perhaps?

As for 3 -- I don't think we want to remove the postgresql branding It
should be made optional though, perhaps by another parameter in said
dict in the settings that would just make it load from different URLs
and files?

--=20
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/