MIME-Version: 1.0
References: 
 <CAAKRu_Z42AAq7N=usSS3UPMtXqbVvsQzktNmH1X20oypyqA_Xg@mail.gmail.com>
In-Reply-To: 
 <CAAKRu_Z42AAq7N=usSS3UPMtXqbVvsQzktNmH1X20oypyqA_Xg@mail.gmail.com>
From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 17 Dec 2025 15:03:04 +0100
Message-ID: 
 <CABUevEzJqKgnRjHscDP1r8kr+04Nozh=HQ=c8SY6Eq7+V_+tqA@mail.gmail.com>
Subject: Re: Public contributor profile pages
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-www@lists.postgresql.org,
	PostgreSQL Contributors <contributors@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000701f930646264eb1"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEzJqKgnRjHscDP1r8kr%2B04Nozh%3DHQ%3Dc8SY6Eq7%2BV_%2BtqA%40mail.gmail.com>
Precedence: bulk

--000000000000701f930646264eb1
Content-Type: text/plain; charset="UTF-8"

On Wed, 17 Dec 2025 at 01:24, Melanie Plageman <melanieplageman@gmail.com>
wrote:

> Hello,
>
> The Contributors Committee is working on a new program to recognize
> specific contributions (e.g. "volunteered at PGConf.dev 2024" or
> "contributed code to PostgreSQL 18"). These would be listed on an
> individual contributor's profile. As a step toward that, we are
> proposing to add public contributor profile pages.
>
> Attached is a patch set which implements this by:
> 1) allowing all those with pgo user accounts to edit their
> "contributions" (currently only enabled for recognized contributors)
> 2) adds a public contributor profile view accessible via
> postgresql.org/community/contributors/[username]
> <http://postgresql.org/community/contributors/%5Busername%5D>
> 3) links all recognized contributors on [1] to their public contributor
> profile
>
> There are quite a few details to work out. A few I know of are:
> - How should opting into a public profile work? What about existing
> recognized contributors, do we opt them all in automatically? Or just
> opt-in Major Contributors since their "Contributions" are already on a
> public web page? (see patch 0003)
> - How to make the public profile URL scheme work for contributors who
> do not have a pgo user account? Or should it work at all?
>
> This is my first real web patch, so I'm sure I did some things in a
> non-pgweb-idiomatic (or non web-idiomatic) way and didn't think of
> lots of things. I'll probably need lots of guidance.
>

Hi!

A couple of comments!

AFAICS with this patch, *every* user who visits their profile gets a
Contributor object created. And they do that even if they don't save their
profile? And the contributions part of the profile shows up for all users,
whether they are contributors at all or not -- not just "all levels of
contributors". That doesn't seem right, surely only those who are
recognized at *some* level should be getting that, and the change is to
list all levels, but not random non-contributors? (And even if it's shown
for non-contributors intentionally, we shouldn't create a database record
for people just viewing things)

Also, when making changes to a model that only changes fields that aren't
actually in the database (such as the change of help_text), instead of
making a migration for that it's better to "backpatch" it into the latest
existing migration. Otherwise we just collect a lot of no-op migrations
that over time will start costing time and annoyance.

And finally, when adding URLs that contain items from a model, you need to
add those URLs to purge_urls() otherwise it will stay cached when edited.
See for example news.NewsArticle as an example of how that's done
dynamically.


As for the questions - I think we should absolutely do opt-in, and I do
think it makes sense to auto-opt-in the current major contributors since
"it's been like that forever and they haven't complained", but listing the
others and in a more visible way there are sure to be some who might not
want it. In particular, maybe we should make the listing of *email* a
separate opt-in/opt-out? That is you can opt-out of being listed
completely, or you can say "list me, but not my email"?

I've thought a bit about it and I do think listing the profiles with the
username in the URL as you have done is in the end good. I don't think
people would care about exposing that one -- and it's already exposed on
for example the commitfest app. But based on that I would go with "does not
show at all if they don't have an account". They won't be able to edit any
information on it anyway, and if they care enough to do that they will
create an account. We will presumably continue to list them in the list of
contributors, just not provide a details page.

I wonder if we really need a separate "report inappropriate profile"? We
should be getting notifications for them, but in particular if we are
seriously worried about this case, we should make the records moderated.
But these are known contributors - I think we can trust them?


-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

--000000000000701f930646264eb1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, 17 Dec =
2025 at 01:24, Melanie Plageman &lt;<a href=3D"mailto:melanieplageman@gmail=
.com">melanieplageman@gmail.com</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">Hello,<br>
<br>
The Contributors Committee is working on a new program to recognize<br>
specific contributions (e.g. &quot;volunteered at PGConf.dev 2024&quot; or<=
br>
&quot;contributed code to PostgreSQL 18&quot;). These would be listed on an=
<br>
individual contributor&#39;s profile. As a step toward that, we are<br>
proposing to add public contributor profile pages.<br>
<br>
Attached is a patch set which implements this by:<br>
1) allowing all those with pgo user accounts to edit their<br>
&quot;contributions&quot; (currently only enabled for recognized contributo=
rs)<br>
2) adds a public contributor profile view accessible via<br>
<a href=3D"http://postgresql.org/community/contributors/%5Busername%5D" rel=
=3D"noreferrer" target=3D"_blank">postgresql.org/community/contributors/[us=
ername]</a><br>
3) links all recognized contributors on [1] to their public contributor pro=
file<br>
<br>
There are quite a few details to work out. A few I know of are:<br>
- How should opting into a public profile work? What about existing<br>
recognized contributors, do we opt them all in automatically? Or just<br>
opt-in Major Contributors since their &quot;Contributions&quot; are already=
 on a<br>
public web page? (see patch 0003)<br>
- How to make the public profile URL scheme work for contributors who<br>
do not have a pgo user account? Or should it work at all?<br>
<br>
This is my first real web patch, so I&#39;m sure I did some things in a<br>
non-pgweb-idiomatic (or non web-idiomatic) way and didn&#39;t think of<br>
lots of things. I&#39;ll probably need lots of guidance.<br></blockquote><d=
iv><br></div><div>Hi!</div><div><br></div><div>A couple of comments!</div><=
div><br></div><div>AFAICS with this patch, *every* user who visits their pr=
ofile gets a Contributor object created. And they do that even if they don&=
#39;t save their profile? And the contributions part of the profile shows u=
p for all users, whether they are contributors at all or not -- not just &q=
uot;all levels of contributors&quot;. That doesn&#39;t seem right, surely o=
nly those who are recognized at *some* level should be getting that, and th=
e change is to list all levels, but not random non-contributors? (And even =
if it&#39;s shown for non-contributors intentionally, we shouldn&#39;t crea=
te a database record for people just viewing things)</div><div><br></div><d=
iv>Also, when making changes to a model that only changes fields that aren&=
#39;t actually in the database (such as the change of help_text), instead o=
f making a migration for that it&#39;s better to &quot;backpatch&quot; it i=
nto the latest existing migration. Otherwise we just collect a lot of no-op=
 migrations that over time will start costing time and annoyance.</div><div=
><br></div><div>And finally, when adding URLs that contain items from a mod=
el, you need to add those URLs to purge_urls() otherwise it will stay cache=
d when edited. See for example news.NewsArticle as an example of how that&#=
39;s done dynamically.</div><div><br></div><div><br></div><div>As for the q=
uestions - I think we should absolutely do opt-in, and I do think it makes =
sense to auto-opt-in the current major contributors since &quot;it&#39;s be=
en like that forever and they haven&#39;t complained&quot;, but listing the=
 others and in a more visible way there are sure to be some who might not w=
ant it. In particular, maybe we should make the listing of *email* a separa=
te opt-in/opt-out? That is you can opt-out of being listed completely, or y=
ou can say &quot;list me, but not my email&quot;?</div><div><br></div><div>=
I&#39;ve thought a bit about it and I do think listing the profiles with th=
e username in the URL as you have done is in the end good. I don&#39;t thin=
k people would care about exposing that one -- and it&#39;s already exposed=
 on for example the commitfest app. But based on that I would go with &quot=
;does not show at all if they don&#39;t have an account&quot;. They won&#39=
;t be able to edit any information on it anyway, and if they care enough to=
 do that they will create an account. We will presumably continue to list t=
hem in the list of contributors, just not provide a details page.</div><div=
><br></div><div>I wonder if we really need a separate &quot;report inapprop=
riate profile&quot;? We should be getting notifications for them, but in pa=
rticular if we are seriously worried about this case, we should make the re=
cords moderated. But these are known contributors - I think we can trust th=
em?</div><div><br></div><div><br></div></div><span class=3D"gmail_signature=
_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=
=3D"ltr"><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a href=3D"http://www.haga=
nder.net/" target=3D"_blank">https://www.hagander.net/</a><br>=C2=A0Work: <=
a href=3D"http://www.redpill-linpro.com/" target=3D"_blank">https://www.red=
pill-linpro.com/</a></div></div></div></div>

--000000000000701f930646264eb1--