public inbox for [email protected]
help / color / mirror / Atom feedExpose version.firstreldate in versions.json
5+ messages / 3 participants
[nested] [flat]
* Expose version.firstreldate in versions.json
@ 2023-10-18 15:03 Corey Huinker <[email protected]>
2023-10-22 19:50 ` Re: Expose version.firstreldate in versions.json Jonathan S. Katz <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Corey Huinker @ 2023-10-18 15:03 UTC (permalink / raw)
To: [email protected]
It's already a part of the versions data structure, and I can see
consumers wanting to know when a major release first came out.
Attachments:
[application/octet-stream] v1-0001-Expose-version.firstreldate-in-versions.json.patch (892B, 3-v1-0001-Expose-version.firstreldate-in-versions.json.patch)
download | inline diff:
From 5df43f8406753afc5585717bea23f8565a5f2140 Mon Sep 17 00:00:00 2001
From: Corey Huinker <[email protected]>
Date: Wed, 18 Oct 2023 10:59:19 -0400
Subject: [PATCH v1] Expose version.firstreldate in versions.json.
It's already a part of the versions data structure, and I can see
consumers wanting to know when a major release first came out.
---
pgweb/core/json.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/pgweb/core/json.py b/pgweb/core/json.py
index 842dc529..ce5ef5da 100644
--- a/pgweb/core/json.py
+++ b/pgweb/core/json.py
@@ -8,6 +8,7 @@ def version_to_json(version):
'major': str(version.numtree),
'latestMinor': str(version.latestminor),
'relDate': version.reldate,
+ 'firstRelDate', version.firstreldate,
'eolDate': version.eoldate,
'current': version.current,
'supported': version.supported,
--
2.41.0
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Expose version.firstreldate in versions.json
2023-10-18 15:03 Expose version.firstreldate in versions.json Corey Huinker <[email protected]>
@ 2023-10-22 19:50 ` Jonathan S. Katz <[email protected]>
2023-10-22 19:52 ` Re: Expose version.firstreldate in versions.json Jonathan S. Katz <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan S. Katz @ 2023-10-22 19:50 UTC (permalink / raw)
To: Corey Huinker <[email protected]>; [email protected]
On 10/18/23 11:03 AM, Corey Huinker wrote:
> It's already a part of the versions data structure, and I can see
> consumers wanting to know when a major release first came out.
LGTM. If no objections I'll apply within 24-48 hours.
Thanks,
Jonathan
Attachments:
[application/pgp-signature] OpenPGP_signature.asc (840B, 2-OpenPGP_signature.asc)
download
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Expose version.firstreldate in versions.json
2023-10-18 15:03 Expose version.firstreldate in versions.json Corey Huinker <[email protected]>
2023-10-22 19:50 ` Re: Expose version.firstreldate in versions.json Jonathan S. Katz <[email protected]>
@ 2023-10-22 19:52 ` Jonathan S. Katz <[email protected]>
2023-10-23 13:40 ` Re: Expose version.firstreldate in versions.json Magnus Hagander <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan S. Katz @ 2023-10-22 19:52 UTC (permalink / raw)
To: Corey Huinker <[email protected]>; [email protected]
On 10/22/23 3:50 PM, Jonathan S. Katz wrote:
> On 10/18/23 11:03 AM, Corey Huinker wrote:
>> It's already a part of the versions data structure, and I can see
>> consumers wanting to know when a major release first came out.
>
> LGTM. If no objections I'll apply within 24-48 hours.
And by "LGTM", I meant I fixed the syntax error so the patch works :)
Thanks,
Jonathan
Attachments:
[application/pgp-signature] OpenPGP_signature.asc (840B, 2-OpenPGP_signature.asc)
download
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Expose version.firstreldate in versions.json
2023-10-18 15:03 Expose version.firstreldate in versions.json Corey Huinker <[email protected]>
2023-10-22 19:50 ` Re: Expose version.firstreldate in versions.json Jonathan S. Katz <[email protected]>
2023-10-22 19:52 ` Re: Expose version.firstreldate in versions.json Jonathan S. Katz <[email protected]>
@ 2023-10-23 13:40 ` Magnus Hagander <[email protected]>
2023-10-23 17:29 ` Re: Expose version.firstreldate in versions.json Jonathan S. Katz <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Magnus Hagander @ 2023-10-23 13:40 UTC (permalink / raw)
To: Jonathan S. Katz <[email protected]>; +Cc: Corey Huinker <[email protected]>; [email protected]
On Sun, Oct 22, 2023 at 9:52 PM Jonathan S. Katz <[email protected]> wrote:
>
> On 10/22/23 3:50 PM, Jonathan S. Katz wrote:
> > On 10/18/23 11:03 AM, Corey Huinker wrote:
> >> It's already a part of the versions data structure, and I can see
> >> consumers wanting to know when a major release first came out.
> >
> > LGTM. If no objections I'll apply within 24-48 hours.
>
> And by "LGTM", I meant I fixed the syntax error so the patch works :)
+1.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Expose version.firstreldate in versions.json
2023-10-18 15:03 Expose version.firstreldate in versions.json Corey Huinker <[email protected]>
2023-10-22 19:50 ` Re: Expose version.firstreldate in versions.json Jonathan S. Katz <[email protected]>
2023-10-22 19:52 ` Re: Expose version.firstreldate in versions.json Jonathan S. Katz <[email protected]>
2023-10-23 13:40 ` Re: Expose version.firstreldate in versions.json Magnus Hagander <[email protected]>
@ 2023-10-23 17:29 ` Jonathan S. Katz <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan S. Katz @ 2023-10-23 17:29 UTC (permalink / raw)
To: Magnus Hagander <[email protected]>; +Cc: Corey Huinker <[email protected]>; [email protected]
On 10/23/23 9:40 AM, Magnus Hagander wrote:
> On Sun, Oct 22, 2023 at 9:52 PM Jonathan S. Katz <[email protected]> wrote:
>>
>> On 10/22/23 3:50 PM, Jonathan S. Katz wrote:
>>> On 10/18/23 11:03 AM, Corey Huinker wrote:
>>>> It's already a part of the versions data structure, and I can see
>>>> consumers wanting to know when a major release first came out.
>>>
>>> LGTM. If no objections I'll apply within 24-48 hours.
>>
>> And by "LGTM", I meant I fixed the syntax error so the patch works :)
>
> +1.
Pushed. Confirmed it's up there.
Thanks,
Jonathan
Attachments:
[application/pgp-signature] OpenPGP_signature.asc (840B, 2-OpenPGP_signature.asc)
download
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2023-10-23 17:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-10-18 15:03 Expose version.firstreldate in versions.json Corey Huinker <[email protected]>
2023-10-22 19:50 ` Jonathan S. Katz <[email protected]>
2023-10-22 19:52 ` Jonathan S. Katz <[email protected]>
2023-10-23 13:40 ` Magnus Hagander <[email protected]>
2023-10-23 17:29 ` Jonathan S. Katz <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox