Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_CB2F7D8B-9FD9-4741-B863-4B16C8D136BF";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: Development of ABI Compliance Checker for official PostgreSQL
 Repo
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: <f27ff897-c0e4-440d-9dfa-c72ad589ecea@eisentraut.org>
Date: Tue, 20 May 2025 14:57:40 -0400
Cc: Mankirat Singh <mankiratsingh1315@gmail.com>,
 pgsql-www@lists.postgresql.org,
 "Pavlo.Golub@gmail.com" <Pavlo.Golub@gmail.com>
Message-Id: <ED6BB3F9-1A81-4BE0-9AB4-D0B35175B4C8@justatheory.com>
References: 
 <CAOtk82TM4W4r50f38yG84Q8QkM216kebniqVid+k9XaEoNb-Vg@mail.gmail.com>
 <F92EE592-ED82-47A0-A6A0-B4AD4539560A@justatheory.com>
 <f27ff897-c0e4-440d-9dfa-c72ad589ecea@eisentraut.org>
To: Peter Eisentraut <peter@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ED6BB3F9-1A81-4BE0-9AB4-D0B35175B4C8%40justatheory.com>
Precedence: bulk


--Apple-Mail=_CB2F7D8B-9FD9-4741-B863-4B16C8D136BF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On May 19, 2025, at 10:17, Peter Eisentraut <peter@eisentraut.org> =
wrote:

> Well, normally (if there are no problematic ABI changes) the report =
will be empty.  So I wouldn't spend too much time on the formatting.  If =
there is a violation, you can just show the raw abidiff output inside =
<pre> or whatever.

Interesting point, though it looks like maybe the output doesn=E2=80=99t =
work that way? In his second post, Mankirat linked to the output from =
abidiff[1] and abicc[2] comparing 17.2 to 17.3. The latter is HTML, but =
abidiff=E2=80=99s plan is pretty straightforward text that reports a =
bunch of changes. I imagine it=E2=80=99ll need some massaging to =
determine which are proper ABI breaks.

Mankirat, did you try it with 17.0 to 17.1? That would be interesting, =
as there was an ABI break in 17.1[3].

> Generally, this looks like the right direction.
>=20
> As an additional tip, check the Python source code, they are doing =
something like that with libabigail as well.

Ooh, good to know, thanks!

D

[1]: =
https://drive.google.com/file/d/1EFW2BHsRglAuNTjF6DpizRiX8iSNBsaN/view
[2]: https://abicc-17-2-17-3-postgres.mankiratsingh.com/
[3]: =
https://www.enterprisedb.com/blog/explaining-abi-breakage-postgresql-171


--Apple-Mail=_CB2F7D8B-9FD9-4741-B863-4B16C8D136BF
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmgs0KQACgkQkt9idPjI
gfFYNRAAmfcgdnsk01INDBMEkWKmXoaQuR+EWkPYVSaOioN5rfirZzRoxtg/JW05
64xRcdR042Y+JjuvBklbe5PbGWXdxfdwgu8OStZLx0D8AZEzU+ugovguAyoS7O4d
X4yJjTIRBsgIqCw0dAgtnR1OztIJAsxwxAkV1dV8hcw3I1wjPRjju8TYRB5BV5Gs
LDoU5G05cXyo5b0ow7y19PcBjLRxipH9Db9+/83YD0ugL0wk3TVtgotrDRCR70bB
vY5Ixva7HuaL0D2PyZZWyOpeOp8RqWtEKeCJ/gV3TBfzWv1B8mCti9NskdXjerCj
IYrPhCTH7f/7Z1xD+K4/MDj3pCO6cqDXjNE5KqbC00kHcxQNw5eJ3J1Aw3bmPn51
UnzDYeHDGTj4MKsMuKpZtgYmnryib+CYwQSN2TBW8PtZE+YvsDRx6fMVlxxU97DE
6hnLcq7ifH3ZaEuEtCBqAgz9Ta3MsWQvXtpCnqfE4Aqar0HutxcFpPrJ3jtkPIzE
wfgMR1hiv8yqJyKnzDj9EdnVlDIi3c6xAFUusjPEuKdoNWdSIfKkdtXWg6b4t3GU
w7toOVxbSZ/IMgQlMwP6ZaiTRwyE1Hzy2OzKMcuKAvjEBdk3JLlNritIUYUBExPu
Djp/AxZWLn0ZM2n7CuTo2DYTSxLSD1Fq7Mn4iTuG8ti+ZagZGbA=
=TWpj
-----END PGP SIGNATURE-----

--Apple-Mail=_CB2F7D8B-9FD9-4741-B863-4B16C8D136BF--