Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xHkMI-00000003HFs-2doZ for pgsql-www@arkaria.postgresql.org; Fri, 16 Oct 2026 16:00:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xHkMH-0000000FE9H-2l00 for pgsql-www@arkaria.postgresql.org; Fri, 16 Oct 2026 16:00:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xHkMH-0000000FE95-1qIq; Fri, 16 Oct 2026 16:00:37 +0000 Received: from stravinsky.debian.org ([2001:41b8:202:deb::311:108]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xHkMF-00000002MN8-028U; Fri, 16 Oct 2026 16:00:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=l6PpFZkYNYZaiVgf44nHRUvcUSXD9m2Z8XfNpz6j2NI=; b=OZTcOWYxOX6as7AHYiAOmby1PY XyGBFVszvg0b4Mj+RJNHXi4/t7TkUIlIn80xyYPqaL15jX9BwE7cZ3B0jxwhkPI9T8HVyZaQCjsrG 2F3n3l9esDLSKVJwnIP5hdOvdHSxhLp62L/Z6JLJGSB2+yhF5u79bvz5ZOcJY5A9+81gOnht5bERt 8el0iFbxqpvk7uzsco/0rUXixP0VC0XuIJeih+lZV7OmcfNeeVzOs2uIa9e8vgUgkCpncSHaODR2R Ceh4ayWeYAmtwKSwBkjgCCJW4p7OlF2X/Njau4XX9+JmNHEjaYpsFp/JPcKXHLvfoiIsZb+Ez+hHC 59GKbJJw==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1xHkM7-0064z4-0g; Fri, 16 Oct 2026 16:00:27 +0000 Date: Fri, 16 Oct 2026 18:00:25 +0200 From: Christoph Berg To: Dave Page , Magnus Hagander Cc: "Jonathan S. Katz" , Daniel Gustafsson , pgsql-www@lists.postgresql.org, Andrey Borodin , Melanie Plageman , PostgreSQL Contributors Subject: Re: Introduce contributor badges: image versioning? Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Debian-User: myon List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Dave Page > That's fair, but items 1 to 3 still stand; the VCL limits how long the > stale pages last, though: Ack, I'll address these separately. Re: Magnus Hagander > Agreed, no need for URL versioning. Thanks. > > > - `badge_image` fetches the image and computes its MD5 before it checks > > > `If-None-Match`; storing the hash would avoid both. > > > > badge_image is only reached on a Varnish miss, and on a miss we're > > almost always about to serve the image anyway. Storing the hash only > > helps the narrow (?) "Django itself receives a conditional request" > > case. > > No, on the vast majority of misses we'd be serving a 304 Found with no > content. Every time an image expires in any of the caches it would send a > conditional request. Is that enough to warrant storing the MD5 in a separate column? The PG xx Contributor images I have here are all between 20 and 40kB in size. (I.e. is that the fix we want?) > (I have not looked at the rest, so I reserve the right to further review) There will be patches coming for the other points soon. Christoph