public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jonathan S. Katz <[email protected]>
To: Christoph Berg <[email protected]>
To: PostgreSQL WWW <[email protected]>
Cc: PostgreSQL Contributors <[email protected]>
Subject: Re: Rename Contributor to Significant Contributor
Date: Mon, 24 Nov 2025 15:31:05 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi Christoph,

On 11/24/25 10:50 AM, Christoph Berg wrote:
> Hi,
> 
> I plan to commit the attached patch to rename Contributor to
> Significant Contributor. Also included is some copy-editing of the
> pages.

Thanks! I reviewed the patch in the downstream attachment. LGTM overall, 
a few notes:

* The fixtures edits will be purely for testing purposes; those changes 
will need to be added into the "Contributor types" section of the admin 
panel.

* I'd note in the commit message that there are a few other cosmetic 
changes and list them out.

> https://www.postgresql.org/about/policies/contributors/:
> 
> * really needs a "Policy" in the page title or everyone is confused
>    why this page isn't listing people

This is fine.

> https://www.postgresql.org/community/contributors/

> * I added a "PostgreSQL" to the (in-page) title so "PostgreSQL
>    Contributor Profiles" sounds better than a mundane "Contributor
>    Profiles" listing

This is fine; I think it's also OK to add it to the title block, since 
it'll appear in search results with that too, but I'm not wed to that 
opinion.

> * I moved the "how to suggest" section to the end so the list isn't
>    cluttered with too much text at the top

I'm not sure what the reasoning was to have it originally up top - maybe 
it was to make it easier to find that info, especially because the page 
is fairly long. I'd be OK with keeping it up top - it's not too much to 
scroll.

> * The sections all have introductory text now (likely needs manual
>    importing of the json file, like the actual "Significant" (and Past
>    Significant Contributor) rename.
> 
> https://www.postgresql.org/about/governance/contributors/:
> 
> * add Floor (already pushed in a separate commit)

LGTM. Thanks!

Joanthan


Attachments:

  [application/pgp-signature] OpenPGP_signature.asc (840B, 2-OpenPGP_signature.asc)
  download

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Rename Contributor to Significant Contributor
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox