Message-ID: <c404df0f-0f6b-f513-fa52-0edc2e569be6@cmatte.me>
Date: Sun, 31 Oct 2021 19:02:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] pglister: Add possibility to override settings.py in
 settings_local.py
Content-Language: en-US
To: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
References: <4de7ef7b-cdb3-2d97-5e6a-444e48b192bf@cmatte.me>
 <CABUevEx=CB6Ka1hjmidDUrsQP01QCLq=T+sLiJVTSiCDD+RQ3Q@mail.gmail.com>
From: =?UTF-8?Q?C=c3=a9lestin_Matte?= <celestin.matte@cmatte.me>
In-Reply-To: 
 <CABUevEx=CB6Ka1hjmidDUrsQP01QCLq=T+sLiJVTSiCDD+RQ3Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/c404df0f-0f6b-f513-fa52-0edc2e569be6%40cmatte.me>
Precedence: bulk

Hello,

> 
> And finally, settings.py already contains:
> try:
>     from .local_settings import *
> except ImportError:
>     pass
> 
> 
> Just a couple of lines above where you are adding it back again. Is that also for some reason not working?

Right, I missed that. It's just that in pgweb and pgarchives, the file is called settings_local.py, whereas pglister calls it local_settings.py. This is just a question of naming consistency, then. Do you think it's worth patching?

> Second, I'm not sure why we want to exclude local_settings.py from pycodestyle in general?

It's ignored in pgweb, I just assumed there was a good reason for that and did the same thing for consistency.

Cheers,
-- 
Célestin Matte