Content-Type: multipart/mixed; boundary="------------RjJOPMg0e0vLYxzgC6zUToqc"
Message-ID: <cee050a6-1dbc-5fa3-459b-555b9d20cee1@cmatte.me>
Date: Wed, 22 Mar 2023 10:32:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCHES] pgarchives: merge schema.sql into Django's model
Content-Language: en-US
To: pgsql-www@lists.postgresql.org, Magnus Hagander <magnus@hagander.net>
References: <12eb75f0-3fc2-14f3-0931-4f29e145f182@cmatte.me>
From: =?UTF-8?Q?C=c3=a9lestin_Matte?= <celestin.matte@cmatte.me>
In-Reply-To: <12eb75f0-3fc2-14f3-0931-4f29e145f182@cmatte.me>
Archived-At: 
 <https://www.postgresql.org/message-id/cee050a6-1dbc-5fa3-459b-555b9d20cee1%40cmatte.me>
Precedence: bulk

This is a multi-part message in MIME format.
--------------RjJOPMg0e0vLYxzgC6zUToqc
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Adding a patch to this series to fix an issue with this migration: default value set in django is not taken account in load_messages.py because django's ORM is not used there, which leads to crashes.

On 03/02/2022 14:30, Célestin Matte wrote:
> As discussed in previous threads before [1, 2], database creations file are currently split between the Django model and a SQL file. Discrepancy in the database's definition exists between them. As a consequence, the database cannot be created easily.
> This series of patches merge schema.sql into Django's model, and adds specific postgres components that cannot be handled by Django's ORM using RunSQL() in a migration file.
> 
> Please also note that I integrated several other patches to avoid multiple migration files:
> - I allowed message.parentid to be null, as discussed in [1]. This can cause Internal Server Errors in views.py, which are fixed by the second patch.
> - I used BinaryFields for bytea columns (message.rawtxt and attachments.attachment), which seems to be the way to integrate bytea into Django
> 
> It may be a good opportunity to remove all mentions of pg_dict, pg_stop and associated file. I'm not sure of the consequences of this. According to [2], these are the remains of an aborted idea.
> Also, what does tsparer bring? Can the installation of pgarchives be simplified by replacing it with pg_catalog.english?
> 
> 
> [1]: https://www.postgresql.org/message-id/CABUevEyFpYPEHh0AAyTAsgymRKOOVA1SY_pDHPCbBQQ9BawfTA%40mail.gmail.com
> [2]: https://www.postgresql.org/message-id/CABUevEy_i1xAKscMv4KZ0%3DbE8050bBcQfWaNyjwZZBofZx7JgQ%40mail.gmail.com

-- 
Célestin Matte

--------------RjJOPMg0e0vLYxzgC6zUToqc
Content-Type: text/x-patch; charset=UTF-8;
 name="0003-Bugfix-set-a-default-value-for-loaderror-column-dat.patch"
Content-Disposition: attachment;
 filename*0="0003-Bugfix-set-a-default-value-for-loaderror-column-dat.pat";
 filename*1="ch"
Content-Transfer-Encoding: base64

RnJvbSAzZTM2NTMyNGZkYjcxOGFmYTYxNGVlMzljNWNmYjU5MDk1NWI5YTRjIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qz1DMz1BOWxlc3Rpbj0yME1hdHRl
Pz0gPGdpdGxhYkBjbWF0dGUubWU+CkRhdGU6IFdlZCwgMjIgTWFyIDIwMjMgMTA6MjU6NDEg
KzAxMDAKU3ViamVjdDogW1BBVENIIDMvM10gQnVnZml4OiBzZXQgYSBkZWZhdWx0IHZhbHVl
IGZvciBsb2FkZXJyb3IgY29sdW1uICJkYXQiCgpBIGRlZmF1bHQgdmFsdWUgZm9yIHRoaXMg
Y29sdW1uIGlzIHNldCBpbiBkamFuZ28gd2l0aCBhdXRvX25vd19hZGQsIGJ1dCB0aGlzCmRl
ZmF1bHQgaXMgbm90IHRha2VuIGludG8gYWNjb3VudCB3aGVuIGRqYW5nbydzIE9STSBpcyBu
b3QgdXNlZCwgc3VjaCBhcyBpbgpsb2FkX21lc3NhZ2UucHksIHdoaWNoIGxlYWRzIHRvIGNy
YXNoZXMKLS0tCiBkamFuZ28vYXJjaGl2ZXMvbWFpbGFyY2hpdmVzL21pZ3JhdGlvbnMvMDAw
NV9tZXJnZV9zY2hlbWEucHkgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr
KQoKZGlmZiAtLWdpdCBhL2RqYW5nby9hcmNoaXZlcy9tYWlsYXJjaGl2ZXMvbWlncmF0aW9u
cy8wMDA1X21lcmdlX3NjaGVtYS5weSBiL2RqYW5nby9hcmNoaXZlcy9tYWlsYXJjaGl2ZXMv
bWlncmF0aW9ucy8wMDA1X21lcmdlX3NjaGVtYS5weQppbmRleCBiNWNlMzFmLi5lZjM4NzQz
IDEwMDY0NAotLS0gYS9kamFuZ28vYXJjaGl2ZXMvbWFpbGFyY2hpdmVzL21pZ3JhdGlvbnMv
MDAwNV9tZXJnZV9zY2hlbWEucHkKKysrIGIvZGphbmdvL2FyY2hpdmVzL21haWxhcmNoaXZl
cy9taWdyYXRpb25zLzAwMDVfbWVyZ2Vfc2NoZW1hLnB5CkBAIC0xMDAsNiArMTAwLDcgQEAg
Y2xhc3MgTWlncmF0aW9uKG1pZ3JhdGlvbnMuTWlncmF0aW9uKToKICAgICAgICAgbWlncmF0
aW9ucy5SdW5TUUwoIkNSRUFURSBVTklRVUUgSU5ERVggaWR4X3VucmVzb2x2ZWRfbXNnaWRf
bWVzc2FnZSBPTiB1bnJlc29sdmVkX21lc3NhZ2VzKG1zZ2lkLCBtZXNzYWdlKTsiKSwKICAg
ICAgICAgbWlncmF0aW9ucy5SdW5TUUwoIkNSRUFURSBJTkRFWCBsaXN0X3RocmVhZHNfbGlz
dGlkX2lkeCBPTiBsaXN0X3RocmVhZHMobGlzdGlkKTsiKSwKICAgICAgICAgbWlncmF0aW9u
cy5SdW5TUUwoIkNSRUFURSBJTkRFWCBpZHhfYXR0YWNobWVudHNfbXNnIE9OIGF0dGFjaG1l
bnRzKG1lc3NhZ2UpOyIpLAorICAgICAgICBtaWdyYXRpb25zLlJ1blNRTCgiQUxURVIgVEFC
TEUgbG9hZGVycm9ycyBBTFRFUiBDT0xVTU4gZGF0IFNFVCBERUZBVUxUIE5PVygpOyIpLAog
ICAgICAgICBtaWdyYXRpb25zLlJ1blNRTCgiIiIKIENSRUFURSBURVhUIFNFQVJDSCBDT05G
SUdVUkFUSU9OIHBnIChDT1BZID0gcGdfY2F0YWxvZy5lbmdsaXNoKTsKIAotLSAKMi4zOS4y
Cgo=

--------------RjJOPMg0e0vLYxzgC6zUToqc--