Subject: Re: Bogus reports from coverage.postgresql.org
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-www@lists.postgresql.org
References: <30022.1520642188@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <d0eec0fd-bf3b-55da-f5de-4fa1c00ce400@2ndquadrant.com>
Date: Sun, 11 Mar 2018 10:08:54 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <30022.1520642188@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/9/18 19:36, Tom Lane wrote:
> I happened to notice that if you look at
> https://coverage.postgresql.org/src/backend/optimizer/util/predtest.c.gcov.html
> it claims that the two occurrences of
> 	elog(ERROR, "predicate_classify returned a bogus value");
> at lines 492 and 803 are reached.
> 
> This would be quite astonishing if true, but it isn't true, since
> the regression tests aren't reporting any such failure.
> 
> Needless to say, this puts quite a damper on my faith in the coverage
> reports.  Maybe that machine needs a software update?

I can't reproduce this locally, so yeah, maybe we should check whether
the toolchain could be updated.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services