Received: from localhost (maia-3.hub.org [200.46.204.184]) by postgresql.org (Postfix) with ESMTP id BAA329FC26D for ; Fri, 9 Mar 2007 02:29:22 -0400 (AST) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.184]) (amavisd-new, port 10024) with ESMTP id 61663-05 for ; Fri, 9 Mar 2007 02:29:17 -0400 (AST) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.4 Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by postgresql.org (Postfix) with ESMTP id 996A29FC0A9 for ; Fri, 9 Mar 2007 02:29:18 -0400 (AST) Received: by nf-out-0910.google.com with SMTP id x4so934198nfb for ; Thu, 08 Mar 2007 22:29:17 -0800 (PST) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=oPDXwX5Fvno/b2eFzZCCYMfOiZ8lIVU97VDnwRAGRGaek0chdkAPwoes37e2gjSPnD7FeEUY8LH3J0JHLKQmgF/RR54Jo6vtkD/GZkIdFSeXK3Gj5oxi2yXqfPsyjzXjqm2OO6fAvyzggjWmg/ID0bXXA+7OSnBQk9m1PJpHgK4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=Ofwoai89oFIPeh/ufq3ipoPHaQ8T/owKZPciYNuQfbKT3FBL2u0yPe2gDsnyM7N4uBbYly0gNa+EeCfVc6RURuSWS5DaZxdC5zes8mMrRIacdJz6dvsALQ8/sSQRpzqpoZ5BKolUHdTh0vS7CyFon1A9NbQDSdzv/bXGY2KbIrc= Received: by 10.82.134.12 with SMTP id h12mr2108396bud.1173421757051; Thu, 08 Mar 2007 22:29:17 -0800 (PST) Received: by 10.82.139.13 with HTTP; Thu, 8 Mar 2007 22:29:17 -0800 (PST) Message-ID: Date: Fri, 9 Mar 2007 11:59:17 +0530 From: NikhilS To: "Simon Riggs" Subject: Re: log_autovacuum Cc: "Alvaro Herrera" , pgsql-patches@postgresql.org In-Reply-To: <1173378696.3641.162.camel@silverbirch.site> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_152112_24075838.1173421757012" References: <1173369949.3641.132.camel@silverbirch.site> <20070308175330.GW4715@alvh.no-ip.org> <1173378696.3641.162.camel@silverbirch.site> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.186 tagged_above=0 required=5 tests=AWL, BAYES_40, HTML_30_40, HTML_MESSAGE, SPF_PASS X-Spam-Level: X-Archive-Number: 200703/137 X-Sequence-Number: 1147 ------=_Part_152112_24075838.1173421757012 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, On 3/9/07, Simon Riggs wrote: > > On Thu, 2007-03-08 at 14:53 -0300, Alvaro Herrera wrote: > > Maybe something like this is better: > > > > LOG: index passes: 1 pages: removed 0, 197 remain tuples: removed > 7199, 2338 remain CPU usage: whatever > > CONTEXT: Automatic vacuuming of table "database.public.w" > > Yours is better. > > I've implemented this: > > LOG: autovac "public.w" index passes: 1 pages: removed 0, 197 remain > tuples: removed 7199, 2338 remain CPU usage: whatever > > I'm happy if this gets removed later, but I think it will help everybody > understand how multi-vacuums are working and what the best way to > specify the controls should be. > > Not sure about the CONTEXT bit. I think its verbose, plus I thought that > was for ERRORs only. I will defer on this point, since I know y'all > understand that better than I. IMHO, it would be good to have both the messages spit out. The earlier message is much better for parsing and the later makes READABLE sense. Regards, Nikhils -- EnterpriseDB http://www.enterprisedb.com ------=_Part_152112_24075838.1173421757012 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi,

On 3/9/07, Simon Riggs <simon@2ndquadrant.com> wrote:
On Thu, 2007-03-08 at 14:53 -0300, Alvaro Herrera wrote:
>  Maybe something like this is better:
>
> LOG: index passes: 1  pages: removed 0, 197 remain  tuples: removed 7199, 2338 remain  CPU usage: whatever
> CONTEXT: Automatic vacuuming of table "database.public.w"

Yours is better.

I've implemented this:

LOG: autovac "public.w" index passes: 1  pages: removed 0, 197 remain
tuples: removed 7199, 2338 remain  CPU usage: whatever

I'm happy if this gets removed later, but I think it will help everybody
understand how multi-vacuums are working and what the best way to
specify the controls should be.

Not sure about the CONTEXT bit. I think its verbose, plus I thought that
was for ERRORs only. I will defer on this point, since I know y'all
understand that better than I.

IMHO, it would be good to have both the messages spit out. The earlier message is much better for parsing and the later makes READABLE sense.

Regards,
Nikhils
 
--
EnterpriseDB               http://www.enterprisedb.com ------=_Part_152112_24075838.1173421757012--