Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mffUd-0006zN-4e for pgsql-www@arkaria.postgresql.org; Wed, 27 Oct 2021 09:45:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mffUc-0007c6-1p for pgsql-www@arkaria.postgresql.org; Wed, 27 Oct 2021 09:45:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mffUb-0007bv-PU for pgsql-www@lists.postgresql.org; Wed, 27 Oct 2021 09:45:09 +0000 Received: from ploudseeker.com ([78.199.165.48]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mffUX-0000rv-VR for pgsql-www@lists.postgresql.org; Wed, 27 Oct 2021 09:45:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cmatte.me; s=myselector; t=1635327904; bh=UEtC0Qr2TIXo91YRcLuCQYn48bx8NJPdSbsk5ePvevU=; h=Date:Subject:To:References:From:In-Reply-To; b=DXv5EN0B14q+n6fQcIus+Ifi2Vy1VciaxSGG266XUDESc79vvpDb4hqDOPItmDNmx zLMwmQvTf/PTA0IKECDJaqOjkwV7NJ7oSVNS7N7iCJut+cuQ9iC0tspvg/CZD3LMUi d/vlGa1qQc93run0Y/Mn2ym2alR6VEwpKcaNKcb+vmhW/AmN0MKs3usSlZs3KiVnIc fTTJgqD35rxWSN4HC8CyZKOMCYl7U9MVuzvmVUeqOw+4s4zm/iIBcYLLWsoijmd9bN Ff4H6zv0wDOFUtj6WPwsd20EKNWC4TOsfB7GGo94Qx0nQ4NfPaQ2q/fCqCRwwEcAxl Yz3K6utscoBEA== Content-Type: multipart/mixed; boundary="------------UNXkA3UgZ1WML2RRD8Zpczix" Message-ID: Date: Wed, 27 Oct 2021 11:45:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] pgweb: Add ARCHIVES_FRONT_ADDRESS to allow configuration of archives Content-Language: en-US To: pgsql-www@lists.postgresql.org References: <6945e6fc-0006-454e-079f-f7b91af2be22@cmatte.me> From: =?UTF-8?Q?C=c3=a9lestin_Matte?= In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------UNXkA3UgZ1WML2RRD8Zpczix Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > This patch adds a new parameter ARCHIVES_FRONT_ADDRESS, which is then never used. Instead it passes in ARCHIVES_SEARCH_SERVER into the templates. > > I'm pretty sure that's not intentional? They should both b ARCHIVES_FRONT_ADDRESS? Oops, indeed, this is the product of a failed git merge --squash. Fixed patch attached. -- Célestin Matte --------------UNXkA3UgZ1WML2RRD8Zpczix Content-Type: text/x-patch; charset=UTF-8; name="0001-Add-ARCHIVES_FRONT_ADDRESS-to-allow-configuration-of.patch" Content-Disposition: attachment; filename*0="0001-Add-ARCHIVES_FRONT_ADDRESS-to-allow-configuration-of.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyMzdhYjI4OTE2NWUzNGI3N2EyMGUxZDFjMTUyY2M5MzU4OTIxMThlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qz1DMz1BOWxlc3Rpbj0yME1hdHRl Pz0gPGdpdGxhYkBjbWF0dGUubWU+CkRhdGU6IFdlZCwgMjcgT2N0IDIwMjEgMTE6NDE6NDUg KzAyMDAKU3ViamVjdDogW1BBVENIXSBBZGQgQVJDSElWRVNfRlJPTlRfQUREUkVTUyB0byBh bGxvdyBjb25maWd1cmF0aW9uIG9mIGFyY2hpdmVzCiBtZXNzYWdlcyBVUkwKCkRvbWFpbiBv ZiBtZXNzYWdlcyBpbiBwZ3dlYidzIHNlYXJjaCBpcyBjdXJyZW50bHkgaGFyZGNvZGVkIGFz IHBvc3RncmVzcWwub3JnCmluIHRlbXBsYXRlcy9zZWFyY2gvbGlzdHNlYXJjaC5odG1sLiBU aGlzIHBhdGNoIGFsbG93cyB0byB1c2UgYW5vdGhlciBkb21haW4KZm9yIGxpbmtzIHRvIG1l c3NhZ2VzIGluIGFyY2hpdmVzIGluIHRoZSBzZWFyY2ggZnVuY3Rpb24uClNpbmNlIHBnYXJj aGl2ZXMnIGRvbWFpbiBjYW4gZGlmZmVyIGZyb20gcGd3ZWIncyBvbmUsIGEgbmV3IHZhcmlh YmxlIGlzIGRlZmluZWQKZm9yIHRoYXQgcHVycG9zZSBpbnN0ZWFkIG9mIHVzaW5nIFNJVEVf Uk9PVC4KLS0tCiBwZ3dlYi9zZWFyY2gvdmlld3MucHkgICAgICAgICAgICB8IDIgKysKIHBn d2ViL3NldHRpbmdzLnB5ICAgICAgICAgICAgICAgIHwgMSArCiB0ZW1wbGF0ZXMvc2VhcmNo L2xpc3RzZWFyY2guaHRtbCB8IDQgKystLQogMyBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvcGd3ZWIvc2VhcmNoL3ZpZXdz LnB5IGIvcGd3ZWIvc2VhcmNoL3ZpZXdzLnB5CmluZGV4IDU2NzMzYzgyLi45YzBiYzZhYyAx MDA2NDQKLS0tIGEvcGd3ZWIvc2VhcmNoL3ZpZXdzLnB5CisrKyBiL3Bnd2ViL3NlYXJjaC92 aWV3cy5weQpAQCAtMTMzLDYgKzEzMyw3IEBAIGRlZiBzZWFyY2gocmVxdWVzdCk6CiAgICAg ICAgICAgICAgICAgJ2xpc3RpZCc6IGxpc3RpZCwKICAgICAgICAgICAgICAgICAnZGF0ZXMn OiBkYXRlb3B0aW9ucywKICAgICAgICAgICAgICAgICAnZGF0ZXZhbCc6IGRhdGV2YWwsCisg ICAgICAgICAgICAgICAgJ2FyY2hpdmVzX3Jvb3QnOiBzZXR0aW5ncy5BUkNISVZFU19GUk9O VF9BRERSRVNTLAogICAgICAgICAgICAgfSkKICAgICAgICAgZWxzZToKICAgICAgICAgICAg IHJldHVybiByZW5kZXIocmVxdWVzdCwgJ3NlYXJjaC9zaXRlc2VhcmNoLmh0bWwnLCB7CkBA IC0yMzYsNiArMjM3LDcgQEAgZGVmIHNlYXJjaChyZXF1ZXN0KToKICAgICAgICAgICAgICdm aXJzdGhpdCc6IGZpcnN0aGl0LAogICAgICAgICAgICAgJ2xhc3RoaXQnOiBtaW4odG90YWxo aXRzLCBmaXJzdGhpdCArIGhpdHNwZXJwYWdlIC0gMSksCiAgICAgICAgICAgICAncXVlcnkn OiByZXF1ZXN0LkdFVFsncSddLAorICAgICAgICAgICAgJ2FyY2hpdmVzX3Jvb3QnOiBzZXR0 aW5ncy5BUkNISVZFU19GUk9OVF9BRERSRVNTLAogICAgICAgICAgICAgJ3BhZ2VsaW5rcyc6 ICImbmJzcDsiLmpvaW4oCiAgICAgICAgICAgICAgICAgZ2VuZXJhdGVfcGFnZWxpbmtzKHBh Z2VudW0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh0b3RhbGhpdHMg LSAxKSAvLyBoaXRzcGVycGFnZSArIDEsCmRpZmYgLS1naXQgYS9wZ3dlYi9zZXR0aW5ncy5w eSBiL3Bnd2ViL3NldHRpbmdzLnB5CmluZGV4IDZjMWNiMjRlLi41ZGY3ZTM5NSAxMDA2NDQK LS0tIGEvcGd3ZWIvc2V0dGluZ3MucHkKKysrIGIvcGd3ZWIvc2V0dGluZ3MucHkKQEAgLTE2 NCw2ICsxNjQsNyBAQCBWQVJOSVNIX1BVUkdFUlMgPSAoKSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAjIEV4dHJhIHNlcnZlcnMgdGhhdAogRE9fRVNJID0gRmFs c2UgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIyBHZW5l cmF0ZSBFU0kgdGFncwogQVJDSElWRVNfU0VBUkNIX1NFUlZFUiA9ICJhcmNoaXZlcy5wb3N0 Z3Jlc3FsLm9yZyIgICAgICAgICAgIyBXaGVyZSB0byBwb3N0IFJFU1QgcmVxdWVzdCBmb3Ig YXJjaGl2ZXMgc2VhcmNoCiBBUkNISVZFU19TRUFSQ0hfUExBSU5URVhUID0gRmFsc2UgICAg ICAgICAgICAgICAgICAgICAgICAgICAjIENvbnRhY3QgQVJDSElWRVNfU0VBUkNIX1NFUlZF UiB3aXRoIGh0dHAgaW5zdGVhZCBvZiBodHRwcworQVJDSElWRVNfRlJPTlRfQUREUkVTUyA9 ICJ3d3cucG9zdGdyZXNxbC5vcmciICAgICAgICAgICAgICAgIyBEb21haW4gdG8gcmVhZCBh cmNoaXZlcyBtZXNzYWdlcwogRlJPTlRFTkRfU01UUF9SRUxBWSA9ICJtYWd1cy5wb3N0Z3Jl c3FsLm9yZyIgICAgICAgICAgICAgICAgIyBXaGVyZSB0byByZWxheSB1c2VyIGdlbmVyYXRl ZCBlbWFpbAogT0FVVEggPSB7fSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIyBPQXV0aCBwcm92aWRlcnMgYW5kIGtleXMKIFBHREdfT1JHX0lE ID0gLTEgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICMgaWQg b2YgdGhlIFBHREcgb3JnYW5pc2F0aW9uIGVudHJ5CmRpZmYgLS1naXQgYS90ZW1wbGF0ZXMv c2VhcmNoL2xpc3RzZWFyY2guaHRtbCBiL3RlbXBsYXRlcy9zZWFyY2gvbGlzdHNlYXJjaC5o dG1sCmluZGV4IDRkMDdkZWQzLi40MmFkY2RiOCAxMDA2NDQKLS0tIGEvdGVtcGxhdGVzL3Nl YXJjaC9saXN0c2VhcmNoLmh0bWwKKysrIGIvdGVtcGxhdGVzL3NlYXJjaC9saXN0c2VhcmNo Lmh0bWwKQEAgLTUzLDEwICs1MywxMCBAQAogICAgIDxoMj5SZXN1bHRzIHt7Zmlyc3RoaXR9 fS17e2xhc3RoaXR9fSBvZiB7JWlmIGhpdGNvdW50ID09IDEwMDAlfW1vcmUgdGhhbiAxMDAw eyVlbHNlJX17e2hpdGNvdW50fX17JWVuZGlmJX0uPC9oMj4KICAgICB7JWlmIHBhZ2VsaW5r cyAlfVJlc3VsdCBwYWdlczoge3twYWdlbGlua3N8c2FmZX19PGJyLz48YnIvPnslZW5kaWYl fQogICAgIHslZm9yIGhpdCBpbiBoaXRzICV9Ci0gICAgICB7e2Zvcmxvb3AuY291bnRlcjB8 YWRkOmZpcnN0aGl0fX0uIDxhIGhyZWY9Imh0dHBzOi8vd3d3LnBvc3RncmVzcWwub3JnL21l c3NhZ2UtaWQve3toaXQubWVzc2FnZWlkfX0iPnt7aGl0LnN1YmplY3R9fTwvYT4gW3t7aGl0 LnJhbmt8ZmxvYXRmb3JtYXQ6Mn19XTxici8+CisgICAgICB7e2Zvcmxvb3AuY291bnRlcjB8 YWRkOmZpcnN0aGl0fX0uIDxhIGhyZWY9Imh0dHBzOi8ve3sgYXJjaGl2ZXNfcm9vdCB9fS9t ZXNzYWdlLWlkL3t7aGl0Lm1lc3NhZ2VpZH19Ij57e2hpdC5zdWJqZWN0fX08L2E+IFt7e2hp dC5yYW5rfGZsb2F0Zm9ybWF0OjJ9fV08YnIvPgogICAgICAgRnJvbSB7e2hpdC5hdXRob3J9 fSBvbiB7e2hpdC5kYXRlfX0uPGJyLz4KICAgICAgIHt7aGl0LmFic3RyYWN0fHNhZmV9fTxi ci8+Ci0gICAgICA8YSBocmVmPSJodHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9tZXNzYWdl LWlkL3t7aGl0Lm1lc3NhZ2VpZH19Ij5odHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9tZXNz YWdlLWlkL3t7aGl0Lm1lc3NhZ2VpZH19PC9hPjxici8+CisgICAgICA8YSBocmVmPSJodHRw czovL3t7IGFyY2hpdmVzX3Jvb3QgfX0vbWVzc2FnZS1pZC97e2hpdC5tZXNzYWdlaWR9fSI+ aHR0cHM6Ly97eyBhcmNoaXZlc19yb290IH19L21lc3NhZ2UtaWQve3toaXQubWVzc2FnZWlk fX08L2E+PGJyLz4KICAgICAgIDxici8+CiAgICAgeyVlbmRmb3IlfQogICAgIHslaWYgcGFn ZWxpbmtzICV9UmVzdWx0IHBhZ2VzOiB7e3BhZ2VsaW5rc3xzYWZlfX08YnIvPjxici8+eyVl bmRpZiV9Ci0tIAoyLjMzLjEKCg== --------------UNXkA3UgZ1WML2RRD8Zpczix--