From: schabi at logix-tt.com (Markus Schaber) Date: Fri, 22 Sep 2006 17:46:42 +0200 Subject: [Pljava-dev] Patch for SQLInput implementation In-Reply-To: <4513F639.3000108@tada.se> References: <4512F5E4.9060600@logix-tt.com> <45139C17.3050006@tada.se> <4513A107.4060809@logix-tt.com> <4513A3ED.3050401@tada.se> <4513E2C0.3050804@logix-tt.com> <4513E52B.5080108@tada.se> <4513F1A0.8020800@logix-tt.com> <4513F639.3000108@tada.se> Message-ID: <45140562.9070003@logix-tt.com> Hi, Thomas, Here's my first attempt for the SQLInput side. (I did not live-test it, and I possibly broke your formatting wr/t tabs/spaces.) It fetches the Endianness from ByteOrder, and changes readShort(), readInt() and readLong() accordingly. I also refactored the readBytes() method to use readShort() internally for the length tag (or should we change the length to int, while we're at it?) Additionally, I added some missing m_handle checks, and moved the m_position check into the synchronized block at read() (which is necessary from my understanding of the java memory model, as position and chunkSize are both not volatile). Could you have a quick look at it? The SQLOutput side will follow soon. :-) Markus -- Markus Schaber | Logical Tracking&Tracing International AG Dipl. Inf. | Software Development GIS Fight against software patents in Europe! www.ffii.org www.nosoftwarepatents.org -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: SQLInput.diff URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 252 bytes Desc: OpenPGP digital signature URL: