From: thomas at tada.se (Thomas Hallgren)
Date: Fri, 22 Sep 2006 22:56:11 +0200
Subject: [Pljava-dev] Patch for SQLOutput implementation
In-Reply-To: <45140A51.8030605@logix-tt.com>
References: <4512F5E4.9060600@logix-tt.com>	<45139C17.3050006@tada.se>
	<4513A107.4060809@logix-tt.com>	<4513A3ED.3050401@tada.se>
	<4513E2C0.3050804@logix-tt.com>	<4513E52B.5080108@tada.se>
	<4513F1A0.8020800@logix-tt.com>	<4513F639.3000108@tada.se>
	<45140A51.8030605@logix-tt.com>
Message-ID: <45144DEB.2050107@tada.se>

Hi Markus,
I looked at it and it looks fine. If you want to do some more work on 
it, then I'll wait until Monday applying it. Are you planning to look at 
the C-code as well? You seem to know how to keep your bits in order :-)

Regards,
Thomas Hallgren


Markus Schaber wrote:
> Hi,
>
> Here's the patch attempt for the SQLOutput side.
>
> First, it seems that the writeBytes() method was broken, it did write
> nothing (not even the length count) for a zero-length array, which lead
> to random garbage being read or worse on readBytes().
>
> I also added some handle checks.
>
> As I also adopted your coding style wr/t {}s, so I included the input
> side again.
>
> I've to quit now, my schedule is tight his afternoon, but I'll see what
> I can do at the weekend and on Monday.
>
> Regards,
> Markus
>
>