public inbox for [email protected]
help / color / mirror / Atom feed[Pljava-dev] Simple patch for java 1.6 compatibility
6+ messages / 0 participants
[nested] [flat]
* [Pljava-dev] Simple patch for java 1.6 compatibility
@ 2010-05-17 16:57
0 siblings, 1 reply; 6+ messages in thread
From: @ 2010-05-17 16:57 UTC (permalink / raw)
Hello,
I'm sending patch that adds support for java 1.6.
New JDBC4(java 1.6) API simple throws exception NotSupoprtedOperation.
(patch -R -p2 <./pljava.diff)
Regards
Petr Michalek
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pljava_1_4_0__java_1_6.diff
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20100517/1c9aa843/attachment.ksh;
^ permalink raw reply [nested|flat] 6+ messages in thread
* [Pljava-dev] Simple patch for java 1.6 compatibility
@ 2010-05-17 17:37
parent:
0 siblings, 3 replies; 6+ messages in thread
From: @ 2010-05-17 17:37 UTC (permalink / raw)
On 5/17/2010 9:57 AM, Petr Mich?lek wrote:
> Hello,
>
> I'm sending patch that adds support for java 1.6.
>
> New JDBC4(java 1.6) API simple throws exception NotSupoprtedOperation.
>
This diff is unreadable. It seems like a diff between 1.4.0 and current
CVS with a ton of changes from tabs to spaces. We need a diff from
current CVS that doesn't have irrelevant whitespace changes.
It's also not clear that such a patch is a great idea unless it retains
the ability to still build with a 1.5 JDK as that still seems to be in use.
Kris Jurka
^ permalink raw reply [nested|flat] 6+ messages in thread
* [Pljava-dev] Simple patch for java 1.6 compatibility
@ 2010-05-17 17:44
parent:
2 siblings, 0 replies; 6+ messages in thread
From: @ 2010-05-17 17:44 UTC (permalink / raw)
My development environment uses Java 1.6 and my production is still on 1.5. When I create new class files, I compile with "-target 1.5" and everything works in both environments.
Am I lucky that this works at all or is the way to use Java 1.6 with PL/Java?
Jon
-----Original Message-----
From: pljava-dev-bounces at pgfoundry.org [mailto:pljava-dev-bounces at pgfoundry.org] On Behalf Of Kris Jurka
Sent: Monday, May 17, 2010 12:38 PM
To: Petr Mich?lek
Cc: pljava-dev at pgfoundry.org
Subject: Re: [Pljava-dev] Simple patch for java 1.6 compatibility
On 5/17/2010 9:57 AM, Petr Mich?lek wrote:
> Hello,
>
> I'm sending patch that adds support for java 1.6.
>
> New JDBC4(java 1.6) API simple throws exception NotSupoprtedOperation.
>
This diff is unreadable. It seems like a diff between 1.4.0 and current
CVS with a ton of changes from tabs to spaces. We need a diff from
current CVS that doesn't have irrelevant whitespace changes.
It's also not clear that such a patch is a great idea unless it retains
the ability to still build with a 1.5 JDK as that still seems to be in use.
Kris Jurka
_______________________________________________
Pljava-dev mailing list
Pljava-dev at pgfoundry.org
http://pgfoundry.org/mailman/listinfo/pljava-dev
^ permalink raw reply [nested|flat] 6+ messages in thread
* [Pljava-dev] Simple patch for java 1.6 compatibility
@ 2010-05-17 17:58
parent:
2 siblings, 0 replies; 6+ messages in thread
From: @ 2010-05-17 17:58 UTC (permalink / raw)
On 05/17/2010 07:37 PM, Kris Jurka wrote:
>
> It's also not clear that such a patch is a great idea unless it
> retains the ability to still build with a 1.5 JDK as that still seems
> to be in use.
>
J2SE 5.0 reached its End of Service Life on November 3, 2009. Not sure I
see any compelling reasons to continue the support for it if Sun no
longer does:
http://java.sun.com/javase/downloads/index_jdk5.jsp
What would stop anyone from upgrading to 1.6?
Regards,
Thomas Hallgren
^ permalink raw reply [nested|flat] 6+ messages in thread
* [Pljava-dev] Simple patch for java 1.6 compatibility
@ 2010-05-17 20:00
parent:
2 siblings, 1 reply; 6+ messages in thread
From: @ 2010-05-17 20:00 UTC (permalink / raw)
I'm sorry, whitespaces was added by Eclipse code formatter.
Cleaned diff against current CVS is attached.
Petr Michalek
Dne 17.5.2010 19:37, Kris Jurka napsal(a):
> On 5/17/2010 9:57 AM, Petr Mich?lek wrote:
>> Hello,
>>
>> I'm sending patch that adds support for java 1.6.
>>
>> New JDBC4(java 1.6) API simple throws exception NotSupoprtedOperation.
>>
>
> This diff is unreadable. It seems like a diff between 1.4.0 and current
> CVS with a ton of changes from tabs to spaces. We need a diff from
> current CVS that doesn't have irrelevant whitespace changes.
>
> It's also not clear that such a patch is a great idea unless it retains
> the ability to still build with a 1.5 JDK as that still seems to be in use.
>
> Kris Jurka
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pljava_cvs_20100517__java_1_6.diff
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20100517/c6d3c46b/attachment.ksh;
^ permalink raw reply [nested|flat] 6+ messages in thread
* [Pljava-dev] Simple patch for java 1.6 compatibility
@ 2010-05-18 00:39
parent:
0 siblings, 0 replies; 6+ messages in thread
From: @ 2010-05-18 00:39 UTC (permalink / raw)
On 5/17/2010 1:00 PM, Petr Mich?lek wrote:
> I'm sorry, whitespaces was added by Eclipse code formatter.
> Cleaned diff against current CVS is attached.
>
This is slightly better, but still contains many, many whitespace
changes. Please review the patch prior to sending it again.
Kris Jurka
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2010-05-18 00:39 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-05-17 16:57 [Pljava-dev] Simple patch for java 1.6 compatibility
2010-05-17 17:37 `
2010-05-17 17:44 `
2010-05-17 17:58 `
2010-05-17 20:00 `
2010-05-18 00:39 `
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox