From: books at ejurka.com (Kris Jurka)
Date: Wed, 16 Jun 2010 13:54:45 -0700
Subject: [Pljava-dev] Compilation with both JDK 5 and JDK 6
In-Reply-To: <AANLkTilWnA0n-fPNra-lDqyqEGw0Wkcv3Wkr9JSduEKt@mail.gmail.com>
References: <AANLkTilWnA0n-fPNra-lDqyqEGw0Wkcv3Wkr9JSduEKt@mail.gmail.com>
Message-ID: <4C193A15.7030409@ejurka.com>

On 6/16/2010 1:35 PM, Muhammad Mansoor wrote:
> Hi,
>
> The attached patch takes care of the following issues.
>
> 1. It adds PostgreSQL 9.0 support.

The code in CVS already supports postgresql 9.0.  You need to create 
your patch from CVS, not from the 1.4.0 source release.

> 2. It has the JDK support patch ( taken from /Petr Mich?lek original
> patch/ )

Your patch has all the problems his does, tons of gratuitous whitespace 
changes.  You should not be reformatting/re-indenting unrelated code.

> 3. It enables PLjava to be compiled with both JDK 5 and JDK 6.

It does not appear to do this.  A quick search through the patch doesn't 
reveal any matches for JDBC4 or USE_JDK6.

Kris Jurka