From: Chapman Flack <chap@anastigmatix.net>
Subject: Re: Nashorn JavaScript removal coming in Java 15
To: Kartik Ohri <kartikohri13@gmail.com>
References: <5EC17E17.7070002@anastigmatix.net>
 <5ED15825.9060504@anastigmatix.net>
 <CAASLQ4OXAb+_J=oK54PH5eYuXjkV9KMsoXEcp-TYaQPqxk1Xbg@mail.gmail.com>
 <5ED270BA.9010001@anastigmatix.net> <5ED3D488.1010401@anastigmatix.net>
 <5ED474CA.3000106@anastigmatix.net>
 <CAASLQ4PfvmgKPp+aFf_r5RsBwigc+EC5Hm2CuzwJSTDCT64i-A@mail.gmail.com>
 <5ED4EA10.4030801@anastigmatix.net>
 <CAASLQ4Px21jyb2vJYSrjF5P0RqhA-G_DDWR9QHG68r+W+AqbxQ@mail.gmail.com>
 <CAASLQ4NYE-TW6hjbkSOuAY2Z4NM2cYzqSQ9ahO2LAUhdP9axeQ@mail.gmail.com>
 <5ED7E74B.9020800@anastigmatix.net>
 <CAASLQ4Od6-0=3+4ENKh1Z-Wcu5Wir-bwUn_ccO2UCmDhoR4vtQ@mail.gmail.com>
 <5EDA576E.2000204@anastigmatix.net>
 <CAASLQ4OzPwZB6GG_cXNW4WU4zpHa6wm8Q3WRWNv5pZpis+gf3w@mail.gmail.com>
 <5EDBA5D9.8090506@anastigmatix.net>
 <CAASLQ4P8e9XfUh17HFhYE4eMtq5-C4dpHQAX+hCsia-UFNAjtA@mail.gmail.com>
 <5EE7AE8C.2040201@anastigmatix.net>
 <CAASLQ4PoMTiTZUPxTR7VS8LLo9tosAMu-89T5ikWub7VbM+r4Q@mail.gmail.com>
 <CAASLQ4OCmNPrxa2fx09ujwH9X=Lc8yKo6BkSa5YgRSL5q=jDuA@mail.gmail.com>
Cc: pljava-dev@lists.postgresql.org
Message-ID: <5EEA6E2C.5030004@anastigmatix.net>
Date: Wed, 17 Jun 2020 15:25:32 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: 
 <CAASLQ4OCmNPrxa2fx09ujwH9X=Lc8yKo6BkSa5YgRSL5q=jDuA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06/17/20 14:36, Kartik Ohri wrote:
> Also, I saw that pljava was failing on Java 15 early builds. Doing some
> digging, I found Nashorn Engine is proposed to be removed from Java 15. So,
> I think it might be the probable cause.

Good catch. So it's gone in 15, eh? I was hoping it might be around
a little longer.

That means it'll be time to add a profile with build-time dependencies
on org.graalvm.js:js and org.graalvm.js:js-scriptengine. That ought to
handle the uses of JS in the build itself (modulo whatever Nashorn ->
GraalJS compatibility kinks we discover).

I see no reason to also depend on the Graal compiler as described in [1];
what JS is being used for in the build doesn't require speed, so we can
keep it simple.

That will leave the problem of the snippets of JS in the self-installer
jar. I really want that jar to Just Work when run on anybody's Java runtime,
without making them download other stuff first.

Copying/shading js.jar and js-scriptengine.jar into it might work, modulo
licensing issues, but it would grow what's now about a 1 MB jar to 16 MB.
Ouch!

Probably time to work on the self-installer Java code and just build in
the work that is currently done in the included JS. That makes it less
transparent and configurable, but it hasn't needed to change much in
several years so it's probably ok.

I wonder if there is some very small, BSD-licensed javax.script engine
for some other language that would work.

Regards,
-Chap