Subject: Building on Java 15, using graaljs in place of Nashorn
To: Kartik Ohri <kartikohri13@gmail.com>
References: <5EC17E17.7070002@anastigmatix.net>
 <CAASLQ4OXAb+_J=oK54PH5eYuXjkV9KMsoXEcp-TYaQPqxk1Xbg@mail.gmail.com>
 <5ED270BA.9010001@anastigmatix.net> <5ED3D488.1010401@anastigmatix.net>
 <5ED474CA.3000106@anastigmatix.net>
 <CAASLQ4PfvmgKPp+aFf_r5RsBwigc+EC5Hm2CuzwJSTDCT64i-A@mail.gmail.com>
 <5ED4EA10.4030801@anastigmatix.net>
 <CAASLQ4Px21jyb2vJYSrjF5P0RqhA-G_DDWR9QHG68r+W+AqbxQ@mail.gmail.com>
 <CAASLQ4NYE-TW6hjbkSOuAY2Z4NM2cYzqSQ9ahO2LAUhdP9axeQ@mail.gmail.com>
 <5ED7E74B.9020800@anastigmatix.net>
 <CAASLQ4Od6-0=3+4ENKh1Z-Wcu5Wir-bwUn_ccO2UCmDhoR4vtQ@mail.gmail.com>
 <5EDA576E.2000204@anastigmatix.net>
 <CAASLQ4OzPwZB6GG_cXNW4WU4zpHa6wm8Q3WRWNv5pZpis+gf3w@mail.gmail.com>
 <5EDBA5D9.8090506@anastigmatix.net>
 <CAASLQ4P8e9XfUh17HFhYE4eMtq5-C4dpHQAX+hCsia-UFNAjtA@mail.gmail.com>
 <5EE7AE8C.2040201@anastigmatix.net>
 <CAASLQ4PoMTiTZUPxTR7VS8LLo9tosAMu-89T5ikWub7VbM+r4Q@mail.gmail.com>
 <CAASLQ4OCmNPrxa2fx09ujwH9X=Lc8yKo6BkSa5YgRSL5q=jDuA@mail.gmail.com>
 <5EEA6E2C.5030004@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5EEFE23D.8080306@anastigmatix.net>
Date: Sun, 21 Jun 2020 18:42:05 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <5EEA6E2C.5030004@anastigmatix.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06/17/20 15:25, Chapman Flack wrote:
> That means it'll be time to add a profile with build-time dependencies
> on org.graalvm.js:js and org.graalvm.js:js-scriptengine. That ought to
> handle the uses of JS in the build itself (modulo whatever Nashorn ->
> GraalJS compatibility kinks we discover).

I have pushed a branch chore/master/denashorn that does that exactly,
when Java 15 or later is detected. It also sets the system property
polyglot.js.nashorn-compat, which lets the existing JavaScript bits
continue to work without any changes.

> Probably time to work on the self-installer Java code and just build in
> the work that is currently done in the included JS. That makes it less
> transparent and configurable, but it hasn't needed to change much in
> several years so it's probably ok.

I ended up refactoring it just slightly so it can be usefully subclassed,
then writing a PL/Java-specific subclass that handles the pathname mapping.
So now it's a self-extracting jar made by adding two extra .class files
rather than just one. Relatively painless.

Kartik, could you check that the branch works with Java 15 in CI?

Now that there is a small PL/Java-specific class file inside the
installer jar, I may go ahead and give it a few extra small methods
useful for testing, just so they could be run from jshell with a
classpath pointing to the jar. It would be a sensible place to put them.

Regards,
-Chap