Subject: Re: PL/Java new build plugin
To: Kartik Ohri <kartikohri13@gmail.com>
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F0D35BA.30904@anastigmatix.net>
 <CAASLQ4NmornyOW8n-qyneLpDVPgV0Js=+=Eys6bw3Y-ZiVbVjA@mail.gmail.com>
 <CAASLQ4OYvTQL7ssG4=QyEqhaB71=AM-svBUYj3uRdWXWoQgBPw@mail.gmail.com>
 <5F0E3972.5070609@anastigmatix.net> <5F0F2DA2.5090603@anastigmatix.net>
 <CAASLQ4N40xn-0S4Nsy0Ld75=Ny719MPUE7_aRP_5nAcAqkAqoQ@mail.gmail.com>
 <CAASLQ4OiWCQQwYFnxAQBe2dC6Ms803RjCMX-9AC2=1m0ZzeDhA@mail.gmail.com>
 <5F12FF49.6090906@anastigmatix.net> <5F12FF80.5020208@anastigmatix.net>
 <CAASLQ4MqSVnhK_GMgq03HcmOKk7a-v7b4L0yfPbtRO=mpqoQtA@mail.gmail.com>
 <5F1338F8.6030506@anastigmatix.net>
 <CAASLQ4OR8ZD4GRNHVGuTzJp_UP-PAcADxcz=uymiSFPpg8EEHQ@mail.gmail.com>
 <5F135B84.8070302@anastigmatix.net>
 <CAASLQ4O=tYGASWB6F+PTiB2L3RbmHcVX8XAbKHyhwBDOodH1zg@mail.gmail.com>
 <CAASLQ4P=c42e342-1YTTCBxA=CKBH2m=DLJN+ZQb5EJW6MyofQ@mail.gmail.com>
 <CAASLQ4NU3BgfCnVxvAbu9vK9+gtPT87xX1uBj57b0y2J6nxi+Q@mail.gmail.com>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F14C34E.4020704@anastigmatix.net>
Date: Sun, 19 Jul 2020 18:03:58 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: 
 <CAASLQ4NU3BgfCnVxvAbu9vK9+gtPT87xX1uBj57b0y2J6nxi+Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07/19/20 04:42, Kartik Ohri wrote:
> With using the System Class Loader as a temporary fix, I have been able to
> get the build working. I have pushed the changes. How can I test with Graal
> or other engines ?

I have just made a pull request on amCap1712/plugin that uses the
two-parented class loader idea. It turns out the idea wasn't completely
broken, but there's only one choice for which parent goes first.

I learned a lot more about how the Java 9 module system changed how
ServiceLoader works. That turns out to be the issue, and not so much
that the application class loader was just being left out. (And it turns
out the application class loader isn't needed to find Nashorn anyway;
the platform class loader can find it.)

To test with Graal, you can (1) do a build with Java 15 and see that
it breaks because Nashorn is gone :), and then (2) merge the
chore/master/denashorn branch and edit the main (parent) pom.xml, and
change the nashorngone profile so the two graal jars are added as
dependencies of org.postgresql:pljava-pgxs instead of maven-antrun-plugin.

Something isn't quite right about the handling of -Dpljava.libjvmdefault;
the C compiler gives syntax errors if I use it (the build succeeds if
I don't). Running with -X shows this being passed to the compiler:

-DPLJAVA_LIBJVMDEFAULT=${pljava.qlibjvmdefault}

so maybe there's a simple problem like one last line in the POM that
got overlooked, or something.

Of course it's kind of guaranteed not to work right on Windows, for
reasons we already know, but it ought to work on Linux.

Regards,
-Chap