Subject: Re: PL/Java new build plugin
To: Kartik Ohri <kartikohri13@gmail.com>
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F0D35BA.30904@anastigmatix.net>
 <CAASLQ4NmornyOW8n-qyneLpDVPgV0Js=+=Eys6bw3Y-ZiVbVjA@mail.gmail.com>
 <CAASLQ4OYvTQL7ssG4=QyEqhaB71=AM-svBUYj3uRdWXWoQgBPw@mail.gmail.com>
 <5F0E3972.5070609@anastigmatix.net> <5F0F2DA2.5090603@anastigmatix.net>
 <CAASLQ4N40xn-0S4Nsy0Ld75=Ny719MPUE7_aRP_5nAcAqkAqoQ@mail.gmail.com>
 <CAASLQ4OiWCQQwYFnxAQBe2dC6Ms803RjCMX-9AC2=1m0ZzeDhA@mail.gmail.com>
 <5F12FF49.6090906@anastigmatix.net> <5F12FF80.5020208@anastigmatix.net>
 <CAASLQ4MqSVnhK_GMgq03HcmOKk7a-v7b4L0yfPbtRO=mpqoQtA@mail.gmail.com>
 <5F1338F8.6030506@anastigmatix.net>
 <CAASLQ4OR8ZD4GRNHVGuTzJp_UP-PAcADxcz=uymiSFPpg8EEHQ@mail.gmail.com>
 <5F135B84.8070302@anastigmatix.net>
 <CAASLQ4O=tYGASWB6F+PTiB2L3RbmHcVX8XAbKHyhwBDOodH1zg@mail.gmail.com>
 <CAASLQ4P=c42e342-1YTTCBxA=CKBH2m=DLJN+ZQb5EJW6MyofQ@mail.gmail.com>
 <CAASLQ4NU3BgfCnVxvAbu9vK9+gtPT87xX1uBj57b0y2J6nxi+Q@mail.gmail.com>
 <5F14C34E.4020704@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F14E15A.4040202@anastigmatix.net>
Date: Sun, 19 Jul 2020 20:12:10 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <5F14C34E.4020704@anastigmatix.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07/19/20 18:03, Chapman Flack wrote:
> To test with Graal, you can (1) do a build with Java 15 and see that
> it breaks because Nashorn is gone :), and then (2) merge the
> chore/master/denashorn branch and edit the main (parent) pom.xml, and
> change the nashorngone profile so the two graal jars are added as
> dependencies of org.postgresql:pljava-pgxs instead of maven-antrun-plugin.

I meant to ask also: is it possible for the plugin configuration's
<script> tag to allow attributes, such as

<script mimetype="application/javascript">
 ...
</script>

or

<script engine="nashorn">...</script>

I have noticed that Maven configurations tend not to use attributes
much, and instead make everything its own element, like

<scriptLanguage>nashorn</scriptLanguage>
<script>...</script>

but I have not checked whether Maven is actually incapable of using
attributes in configs, or that has just been a common style among
existing plugins.

I would find the style with an attribute to be more compact and
clear.

Regards,
-Chap