Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0F3p-0007tv-Te for pljava-dev@arkaria.postgresql.org; Tue, 28 Jul 2020 02:09:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k0F3n-0002kJ-Vm for pljava-dev@arkaria.postgresql.org; Tue, 28 Jul 2020 02:09:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0F3n-0002kC-Fk for pljava-dev@lists.postgresql.org; Tue, 28 Jul 2020 02:09:43 +0000 Received: from anastigmatix.net ([68.171.219.55]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0F3k-0003Vy-MJ for pljava-dev@lists.postgresql.org; Tue, 28 Jul 2020 02:09:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=anastigmatix.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rcvaVZ59fdhqMmOsKrxIjJgpk9gjWxE+XnMeKQ17mnw=; b=nszgbkt2glTlMHjylkqNj90HBj oVhVG3fOaK7H0Ac9I0dV5g483CyT8bc1k60VJENCKLJjBbqzQiGiDdpkht/OKljBu50MGI9Z7LOvb U7FznxnlWyJ2lDzrN/aDKVkL0POYIBrbXxV0CfzQPyVhHLwmYYnVdnC0YxVLkt5TDQARle7qTf0DU KmA7foQDTK7lhtaspeXBAGdX9EcAgy9sCiGn8EC2lDoTqvKu9oe0We6CGbWO0nEbsrjoqpoLOw9PE ks6fWtT4orxmQwyDM/z1Cst9IBmmIVGXOPl0A9ll8Q2hctmCMQVhnl57vT08NfAwiDoQ0zQ+fHO/5 kIYyEhhw==; Received: from [184.19.31.139] (port=38912) by bay.acenet.us with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1k0F3h-0050Ad-8d; Mon, 27 Jul 2020 22:09:37 -0400 Subject: Re: PL/Java new build plugin To: Kartik Ohri References: <5F1735ED.6020707@anastigmatix.net> <5F1753C9.4060500@anastigmatix.net> <5F175F40.1000905@anastigmatix.net> <5F18C58F.8060204@anastigmatix.net> <5F19C36C.70905@anastigmatix.net> <5F1C6F06.2020809@anastigmatix.net> <5F1CE067.2060107@anastigmatix.net> Cc: pljava-dev@lists.postgresql.org From: Chapman Flack X-Enigmail-Draft-Status: N1110 Message-ID: <5F1F88E0.2050305@anastigmatix.net> Date: Mon, 27 Jul 2020 22:09:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-95.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bay.acenet.us X-AntiAbuse: Original Domain - lists.postgresql.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - anastigmatix.net X-Get-Message-Sender-Via: bay.acenet.us: authenticated_id: chap@anastigmatix.net X-Authenticated-Sender: bay.acenet.us: chap@anastigmatix.net X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 07/27/20 06:45, Kartik Ohri wrote: > Hi! The initial version of the javadoc mojo is ready. I have pushed the > changes. For now, I have just exposed a function using which arguments > could be added to the javadoc tool. I also wrote some script for making the > tool work. The javadoc tool works for pljava-api but not for pljava. I am > trying to debug this. It also works for PL/Java Examples. I have hardcoded That looks like a good start. I wonder if the explicit start of a subprocess could be replaced with javax.tools.ToolProvider.getSystemDocumentationTool() and the corresponding API. I think that could be simple enough to just directly use from the JavaScript, which would mean the mojo would not have to be called JavadocMojo or have Javadoc-specific functionality built in. It could concentrate on being a plugin that allows scripting of new reports in general to run in the site lifecycle. > I did not try to go the interface route yet because I am not sure of the > order in which maven calls these methods. Because if maven calls these > methods before the executeReport method it would be of no use. It might (or, then again, might not) work to guard against that concern by factoring some initialization code into a method of its own, to be called from wrappers around the various interface methods. Regards, -Chap