Subject: Re: PL/Java new build plugin
To: Kartik Ohri <kartikohri13@gmail.com>
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F19C36C.70905@anastigmatix.net>
 <CAASLQ4M_f8cYmxfX5Jqgm9AJHsX62_Cc5pvniXjer4jAZOMOBQ@mail.gmail.com>
 <CAASLQ4Pcp24U3rkWkGvcidTfCLQEsAE1it7b3Sr_uNbgO3P9kA@mail.gmail.com>
 <5F1C6F06.2020809@anastigmatix.net> <5F1CE067.2060107@anastigmatix.net>
 <CAASLQ4OZyt3QL5ZCH0JQyZvuOWTEOgOpko4fC+DPDXgJV0HuPw@mail.gmail.com>
 <5F1F88E0.2050305@anastigmatix.net>
 <CAASLQ4PyG-YvKUTYdqfuQW8yGL+t_93b1i2CMTusoYHbZ0ZTMg@mail.gmail.com>
 <CAASLQ4MDUNP_4BAqK7ZtxtqG7ErH6skMKbNRvL0vE58wdRVxiQ@mail.gmail.com>
 <5F20E585.6010703@anastigmatix.net>
 <CAASLQ4PEcB-Rf1-vFtKCLNxVC6YZsSrzRUd_5TXZsPJp74vvcg@mail.gmail.com>
 <CAASLQ4M1dg+z+J44g77cvzSe3y8q01kWbvCcgoyNzA0j=apfAA@mail.gmail.com>
 <5F22DF79.2090701@anastigmatix.net>
 <CAASLQ4POay=ZLsdOb02n6NqwTn7MGyyWQprcCEo2Wm6Y6rStEw@mail.gmail.com>
 <5F230337.3040406@anastigmatix.net>
 <CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F232EBB.9030208@anastigmatix.net>
Date: Thu, 30 Jul 2020 16:34:03 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: 
 <CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07/30/20 16:13, Kartik Ohri wrote:
> I saw you had used project.build.sourceEncoding which is the default value
> of inputEncoding [1]. Only if this value is null, the getInputEncoding
> method returns ReaderFactory.FILE_ENCODING [2]. But since javadoc is not
> complaining in the current implementation, the null case does not
> apply. So, this will be probably redundant. A similar argument for output
> encoding, it uses a different value which can also be interpolated directly
> in the pom. Should I still expose public methods calling these ?

As you say, the importance is kind of minor ... but if the effort required
is also minor, it is probably worthwhile, just because it allows a script
snippet to be written in a way that will look 'right' on its face to any
casual reader, who need not know as much of the implementation detail
as you do.

Might be simplest just to override them, loosening the access modifier
to public and calling the super method. As 'this' is already available
to the script, maybe nothing more is needed.

Regards,
-Chap