Subject: Re: PL/Java new build plugin
To: Kartik Ohri <kartikohri13@gmail.com>
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F1CE067.2060107@anastigmatix.net>
 <CAASLQ4OZyt3QL5ZCH0JQyZvuOWTEOgOpko4fC+DPDXgJV0HuPw@mail.gmail.com>
 <5F1F88E0.2050305@anastigmatix.net>
 <CAASLQ4PyG-YvKUTYdqfuQW8yGL+t_93b1i2CMTusoYHbZ0ZTMg@mail.gmail.com>
 <CAASLQ4MDUNP_4BAqK7ZtxtqG7ErH6skMKbNRvL0vE58wdRVxiQ@mail.gmail.com>
 <5F20E585.6010703@anastigmatix.net>
 <CAASLQ4PEcB-Rf1-vFtKCLNxVC6YZsSrzRUd_5TXZsPJp74vvcg@mail.gmail.com>
 <CAASLQ4M1dg+z+J44g77cvzSe3y8q01kWbvCcgoyNzA0j=apfAA@mail.gmail.com>
 <5F22DF79.2090701@anastigmatix.net>
 <CAASLQ4POay=ZLsdOb02n6NqwTn7MGyyWQprcCEo2Wm6Y6rStEw@mail.gmail.com>
 <5F230337.3040406@anastigmatix.net>
 <CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
 <5F232EBB.9030208@anastigmatix.net>
 <CAASLQ4OknEQTpSeoBfyAZR1na-EyL+AtN9t0fPGyv5DfWJOSWA@mail.gmail.com>
 <CAASLQ4NHROvOq-rUz6Jn0dUd7oAq3_P655WNeqKksNBqFtAGgw@mail.gmail.com>
 <CAASLQ4OCLUYXpkk0tTioz8=zc4UEbAm-Whgp_5K7uy-5hZdjKA@mail.gmail.com>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F278CCE.1090006@anastigmatix.net>
Date: Mon, 3 Aug 2020 00:04:30 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: 
 <CAASLQ4OCLUYXpkk0tTioz8=zc4UEbAm-Whgp_5K7uy-5hZdjKA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/02/20 13:58, Kartik Ohri wrote:
> (Sorry, for the multiple emails. It was some issue with my internet
> connection.)
> 
> On Sun, Aug 2, 2020, 11:20 PM Kartik Ohri <kartikohri13@gmail.com> wrote:
> 
>> Hi! I wanted to ask if you have been able to take a look at the latest
>> changes ?

Thanks for the reminder, I had not. I have just looked over the commit diff
and from there they look good. I had never used the Nashorn getter-method /
property equivalence before. That's kind of tidy.

I just noticed, comparing to how the current documentation site looks,
the maven-javadoc-plugin actually doesn't produce a vestigial Doxia
report containing a link to the javadocs. It somehow arranges for the
link to the JavaDocs report to go directly to apidocs/index.html.

I'm sorry I hadn't spotted that before. Have you seen how they did that?
It would be a nicer experience, and maybe would make the scripting shorter
also. (And eliminate the temptation to write a fluent wrapper around Sink.)

For git commit messages, there's a kind of widely followed but unofficial
convention to have a top-line summary of no more than 50 characters,
then a blank line and any further description as paragraphs below that.

I guess it's a little bit official; 'git help commit' mentions it:

  Though not required, it's a good idea to begin the commit message with
  a single short (less than 50 character) line summarizing the change,
  followed by a blank line and then a more thorough description. The text
  up to the first blank line in a commit message is treated as the commit
  title, and that title is used throughout Git. For example, git-format-
  patch(1) turns a commit into email, and it uses the title on the
  Subject line and the rest of the commit in the body.

If you use commandline git commit and it starts up vim, you'll notice
the first line as you are typing will change color at character 50, just
as a kind of gentle reminder.

Regards,
-Chap