Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3AH6-0000gl-El for pljava-dev@arkaria.postgresql.org; Wed, 05 Aug 2020 03:39:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k3AH3-0003cb-5M for pljava-dev@arkaria.postgresql.org; Wed, 05 Aug 2020 03:39:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3AH2-0003cU-MB for pljava-dev@lists.postgresql.org; Wed, 05 Aug 2020 03:39:29 +0000 Received: from anastigmatix.net ([68.171.219.55]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3AGv-0006m6-1D for pljava-dev@lists.postgresql.org; Wed, 05 Aug 2020 03:39:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=anastigmatix.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3h7AvZx4qIgzORHGgFu6htpkpUgK5omyZAV0w32gIR4=; b=dbUm9W1iKTxxr25SeKKoHxDQ4e lyIAq7JLMLZQwBtbyKYbnWLe8KbVhs9OaVkdN0FWTsVnsJdXCCvyEAxPDlw6ssp2WX9p0RPQzvL7z Fo9dLwcr1wcIzhYdLFqN00tjk9UMEct9hoKQS9oIvmWTuOr9r9+5My7yLPQhlVNRsfmTg7Ca17eGM rZ5FiOeZsVu5BP7ty7S0csSxTdrM0JZpypDD5XXgU81DtEYm7Lwj4UIf3gCxeX1fwDKK19vwkp6qY YiblCNpcCXWvZukc1rBhiN7X7xWBn6B7pEiZGIjECxAr1QGJkBpfpLeql6hTnste5V1DxI4KDargj BOYKMNSw==; Received: from [184.19.31.139] (port=54102) by bay.acenet.us with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1k3AGr-009yYW-GT; Tue, 04 Aug 2020 23:39:18 -0400 Subject: Re: PL/Java new build plugin To: Kartik Ohri References: <5F20E585.6010703@anastigmatix.net> <5F22DF79.2090701@anastigmatix.net> <5F230337.3040406@anastigmatix.net> <5F232EBB.9030208@anastigmatix.net> <5F278CCE.1090006@anastigmatix.net> <5F2897AF.9040909@anastigmatix.net> Cc: pljava-dev@lists.postgresql.org From: Chapman Flack Message-ID: <5F2A29E4.2000803@anastigmatix.net> Date: Tue, 4 Aug 2020 23:39:16 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-95.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bay.acenet.us X-AntiAbuse: Original Domain - lists.postgresql.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - anastigmatix.net X-Get-Message-Sender-Via: bay.acenet.us: authenticated_id: chap@anastigmatix.net X-Authenticated-Sender: bay.acenet.us: chap@anastigmatix.net X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 08/04/20 08:07, Kartik Ohri wrote: > how it would work. I did try to go this route but I felt that it was > getting a bit difficult. So, after some thinking I moved the hard coded > values to the default values of the interface and utilised it in the mojo. > This approach worked well and I have pushed the changes. I have also pushed > a working example to test it. Please review it and let me know if changes > are required. I've created a branch https://github.com/jcflack/pljava/commits/invocable where you can see the way I had in mind for it to work. It seems to, although javadoc still seems to be ignoring my --show-packages all, as I had noticed before; I still don't know why, but I don't think it's the mojo's fault. Regards, -Chap