Subject: Re: PL/Java new build plugin
To: Kartik Ohri <kartikohri13@gmail.com>
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <CAASLQ4PEcB-Rf1-vFtKCLNxVC6YZsSrzRUd_5TXZsPJp74vvcg@mail.gmail.com>
 <CAASLQ4M1dg+z+J44g77cvzSe3y8q01kWbvCcgoyNzA0j=apfAA@mail.gmail.com>
 <5F22DF79.2090701@anastigmatix.net>
 <CAASLQ4POay=ZLsdOb02n6NqwTn7MGyyWQprcCEo2Wm6Y6rStEw@mail.gmail.com>
 <5F230337.3040406@anastigmatix.net>
 <CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
 <5F232EBB.9030208@anastigmatix.net>
 <CAASLQ4OknEQTpSeoBfyAZR1na-EyL+AtN9t0fPGyv5DfWJOSWA@mail.gmail.com>
 <CAASLQ4NHROvOq-rUz6Jn0dUd7oAq3_P655WNeqKksNBqFtAGgw@mail.gmail.com>
 <CAASLQ4OCLUYXpkk0tTioz8=zc4UEbAm-Whgp_5K7uy-5hZdjKA@mail.gmail.com>
 <5F278CCE.1090006@anastigmatix.net>
 <CAASLQ4M8cN20L7cyVEgks9qdnfsXH4ci7iQbmyi4v_y0W85eLA@mail.gmail.com>
 <5F2897AF.9040909@anastigmatix.net>
 <CAASLQ4MLFnD3v_fqrUj+Bwc9MSBG-ATet3J7UXebzXHTH_si3A@mail.gmail.com>
 <5F2A29E4.2000803@anastigmatix.net>
 <CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F2EB313.8090706@anastigmatix.net>
Date: Sat, 8 Aug 2020 10:13:39 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: 
 <CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/08/20 10:00, Kartik Ohri wrote:
> On Wed, Aug 5, 2020 at 9:09 AM Chapman Flack <chap@anastigmatix.net> wrote:
> 
>> On 08/04/20 08:07, Kartik Ohri wrote:
>>
>>> how it would work. I did try to go this route but I felt that it was
>>> getting a bit difficult. So, after some thinking I moved the hard coded
>>> values to the default values of the interface and utilised it in the
>> mojo.
>>> This approach worked well and I have pushed the changes. I have also
>> pushed
>>> a working example to test it. Please review it and let me know if changes
>>> are required.
>>
>> I've created a branch
>> https://github.com/jcflack/pljava/commits/invocable
>> where you can see the way I had in mind for it to work.
>>
>> I took a look and this way seems to be really better than how I had done
> it. Now that I look at it I feel if I had tried harder, I could have made
> it work myself. I'll try harder next time. Thanks for helping with this.
> I'll merge this into my branch and begin work on the nar maven part.

Works out better than either person working alone. It's nice to have
a collaborator. :)

After you merge, would you mind creating a new branch name from that
point, before continuing with the nar-maven part? I don't mind if it's
a new name for the nar-maven part, or you keep 'plugin' for that part
and use a new name to point to this reporting part.

I think the reporting part will be just about ready for a pull request
soon, so branching will allow us to do that while you continue with
the nar stuff.

I am still working on one more commit or so to get the relative links
between javadoc for different modules working right. (Javadoc seems to
have a misfeature that interferes; in the published docs on the site,
I only got it working by using absolute URLs instead, to the actual
tada.github.io site, but of course that makes them broken when testing
in a local staging directory, and makes it harder to one day support
publishing docs for > 1 PL/Java version. So I really want to solve
the relative-link problem.)

Regards,
-Chap